Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checksum checks for cri-tools #258

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Jan 23, 2023

What this PR does / why we need it:

cri-tools changed the format of their checksums file. Previously, they had <checksum> */<filename>. This was breaking sha256sum so we had to do some magic to fix it.

Nowadays, they just provide the checksum (<checksum>), which also breaks sha256sum so we need to adjust our magic just a little bit.

What type of PR is this?
/kind cleanup

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

Signed-off-by: Marko Mudrinić <[email protected]>
@xmudrii xmudrii requested a review from moadqassem January 23, 2023 16:24
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 23, 2023
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fe28177630ff3d073d50d810d06bf2ce5adf743f

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2023
@kubermatic-bot kubermatic-bot merged commit 8688a1f into kubermatic:main Jan 23, 2023
@xmudrii xmudrii deleted the cri-tools-checksums branch January 23, 2023 17:51
xmudrii added a commit to xmudrii/operating-system-manager that referenced this pull request Jan 24, 2023
Signed-off-by: Marko Mudrinić <[email protected]>

Signed-off-by: Marko Mudrinić <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants