Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CentOS support from machine controller #1876

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Remove CentOS support from machine controller #1876

merged 2 commits into from
Nov 18, 2024

Conversation

adoi
Copy link
Contributor

@adoi adoi commented Nov 13, 2024

What this PR does / why we need it:
Removes CentOS from the list of supported operating systems within machine controller, as part of dropping support for CentOS across KKP, operating system manager, and machine controller.

CentOS 7 has reached EOL, we are no longer planning to support CentOS within the system.

Which issue(s) this PR fixes:

Fixes kubermatic/kubermatic#13580

What type of PR is this?

/kind cleanup
/kind chore

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Remove support for CentOS.

Documentation:

NONE

@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/chore Updating grunt tasks etc; no production code changes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 13, 2024
@adoi
Copy link
Contributor Author

adoi commented Nov 13, 2024

/retest

@adoi
Copy link
Contributor Author

adoi commented Nov 14, 2024

/test pull-machine-controller-e2e-vsphere

@xrstf
Copy link
Contributor

xrstf commented Nov 15, 2024

/override pull-machine-controller-e2e-azure
/override pull-machine-controller-e2e-vsphere

@kubermatic-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-azure, pull-machine-controller-e2e-vsphere

In response to this:

/override pull-machine-controller-e2e-azure
/override pull-machine-controller-e2e-vsphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adoi adoi requested a review from xrstf November 15, 2024 17:21
embik
embik approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ffdf4b6df5691a7381e1aa44c2c78fcadd58921a

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2024
@kubermatic-bot kubermatic-bot merged commit 4f251c4 into kubermatic:main Nov 18, 2024
19 checks passed
@julioc-p
Copy link

julioc-p commented Dec 5, 2024

/cherrypick release/v1.60

@kubermatic-bot
Copy link
Contributor

@julioc-p: new pull request created: #1883

In response to this:

/cherrypick release/v1.60

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik approved these changes

@xrstf xrstf Awaiting requested review from xrstf

Assignees

@embik embik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CentOS 7 has reached EOL
5 participants
@adoi @xrstf @kubermatic-bot @julioc-p @embik