Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anexia: extend network configuration to allow multi-interface and multi-IP #1845

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Anexia: extend network configuration to allow multi-interface and multi-IP #1845

merged 1 commit into from
Aug 21, 2024

Conversation

LittleFox94
Copy link
Contributor

What this PR does / why we need it:

Can now create multiple network interfaces, each with multiple addresses (one from each configured prefix), easily allowing Machines to have e.g. an IPv4 and IPv6 address.

What type of PR is this?

/kind feature

Special notes for your reviewer:

We had an internal review already, which you see in the PR of our fork: anexia-it#23

Might add some context if something looks odd.

Does this PR introduce a user-facing change? Then add your Release Note here:

Anexia: extend network configuration, allowing multiple interfaces and multiple IPs per interface

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 20, 2024
@kubermatic-bot
Copy link
Contributor

Hi @LittleFox94. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 20, 2024
@ahmedwaleedmalik
Copy link
Member

/ok-to-test

@kubermatic-bot kubermatic-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 20, 2024
@ahmedwaleedmalik ahmedwaleedmalik self-requested a review August 20, 2024 13:08
@ahmedwaleedmalik
Copy link
Member

Some files are missing the boilerplate

@LittleFox94
Copy link
Contributor Author

Some files are missing the boilerplate

oops, gonna fix - sorry!

@LittleFox94 LittleFox94 mentioned this pull request Aug 20, 2024
Closed
Anexia: extend network configuration
49780c3 
Can now create multiple network interfaces, each with multiple addresses
(one from each configured prefix), easily allowing Machines to have e.g.
an IPv4 and IPv6 address.

Signed-off-by: Mara Sophie Grosch <[email protected]>
@LittleFox94
Copy link
Contributor Author

@ahmedwaleedmalik the failed GCE tests look very unrelated, can we ignore them?

@ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik the failed GCE tests look very unrelated, can we ignore them?

Yes, it's unrelated and looks like a flake anyways

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5c5662877bc2889514d4fe1d64f83a877bafb1bd

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2024
@kubermatic-bot kubermatic-bot merged commit 107e351 into kubermatic:main Aug 21, 2024
12 checks passed
LittleFox94 added a commit to anexia-it/machine-controller that referenced this pull request Sep 10, 2024
@LittleFox94
Anexia: extend network configuration (kubermatic#1845)
6a15e92 
Can now create multiple network interfaces, each with multiple addresses
(one from each configured prefix), easily allowing Machines to have e.g.
an IPv4 and IPv6 address.

Signed-off-by: Mara Sophie Grosch <[email protected]>
@nachtjasmin nachtjasmin deleted the anexia-multi-ip branch October 17, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LittleFox94 @kubermatic-bot @ahmedwaleedmalik