Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anexia: various patches (request/response logging, CPU performance type, 404 fix on delete) #1797

Merged
merged 3 commits into from
May 14, 2024
Merged

Anexia: various patches (request/response logging, CPU performance type, 404 fix on delete) #1797

merged 3 commits into from
May 14, 2024

Conversation

LittleFox94
Copy link
Contributor

What this PR does / why we need it:

We found some old patches that are probably still worth adding and I combined them with a new feature here in this PR:

  • use pkg/cloudprovider/util.HttpClient to enable request/response logging
  • fix handling for 404 responses when deleting a VM
  • add config attribute to specify the CPU performance type

What type of PR is this?
/kind bug
/kind feature

Special notes for your reviewer:

Since this is all localized in the Anexia provider and all just small changes, I figured there's no harm in combining that into a single PR.

Does this PR introduce a user-facing change? Then add your Release Note here:

Anexia: you can now configure the CPU performance type

Documentation:

I extended the example MachineDeployment in this repository.

NONE

@kubermatic-bot kubermatic-bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 14, 2024
@kubermatic-bot
Copy link
Contributor

Hi @LittleFox94. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels May 14, 2024
@LittleFox94 LittleFox94 force-pushed the anexia-various-patches branch from ba549ba to c3b5142 Compare May 14, 2024 11:26
Mara Sophie Grosch added 3 commits May 14, 2024 13:28
Anexia: really handle 404 response for DELETE
e68fb63 
There already was a check for a 404 error being returned, but the client
library does not actually return 404 as error. Workaround is needed, as
that won't be fixed in go-anxcloud, as it's the legacy client - but
nicely commented and good workaround.

Signed-off-by: Mara Sophie Grosch <[email protected]>
Anexia: use cloudproviderutil.HttpClient
365e3fa 
This way we get request/response logging if required - even prefixed
with the Machine name, if applicable.

Signed-off-by: Mara Sophie Grosch <[email protected]>
Anexia: allow to specify CPU performance type
e18ea59 
Signed-off-by: Mara Sophie Grosch <[email protected]>
@LittleFox94 LittleFox94 force-pushed the anexia-various-patches branch from c3b5142 to e18ea59 Compare May 14, 2024 11:29
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. and removed dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels May 14, 2024
ahmedwaleedmalik
ahmedwaleedmalik approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6f02a1eb6d6af33188644f4956ad1c15b8a2796e

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
@kubermatic-bot kubermatic-bot merged commit f718485 into kubermatic:main May 14, 2024
12 checks passed
@LittleFox94
Copy link
Contributor Author

@ahmedwaleedmalik any chance this could be backported to v1.59 and released?

@ahmedwaleedmalik
Copy link
Member

/cherry-pick release/v1.59

@kubermatic-bot kubermatic-bot mentioned this pull request May 21, 2024
Merged
@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: new pull request created: #1798

In response to this:

/cherry-pick release/v1.59

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahmedwaleedmalik
Copy link
Member

@LittleFox94 We can backport this, but I'm not yet sure when we'll have the new patch releases for v1.59.

@LittleFox94
Copy link
Contributor Author

@LittleFox94 We can backport this, but I'm not yet sure when we'll have the new patch releases for v1.59.

I guess just having it ready on that branch for the next release seems worth it already :)
Thanks!

@ahmedwaleedmalik
Copy link
Member

Contributor

Awesome, sounds good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LittleFox94 @kubermatic-bot @ahmedwaleedmalik