-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exact string match fails, use conventional errors.Is instead #1526
Conversation
Hi @furkhat. Thanks for your PR. I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Furkhat Kasymovgeniiuulu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 7e79656e2b726651e9ecaba71ee832509f743f70
|
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, furkhat, xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…tic#1526) Signed-off-by: Furkhat Kasymovgeniiuulu <[email protected]> Signed-off-by: Furkhat Kasymovgeniiuulu <[email protected]>
…tic#1526) Signed-off-by: Furkhat Kasymovgeniiuulu <[email protected]> Signed-off-by: Furkhat Kasymovgeniiuulu <[email protected]>
What this PR does / why we need it:
Fixes a bug when machine-controller fails on 404 when deleting already gone floating-ip or server.
Example failure
Exact string match against
"Resource not found"
does not work because gophercloud v1.1.1, as well as previous versions, returnWhich issue(s) this PR fixes:
Fixes #
What type of PR is this?
/kind bug
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: