Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dualstack IPv6 addr assignment issue in rockylinux and RHEL #1430

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Fix dualstack IPv6 addr assignment issue in rockylinux and RHEL #1430

merged 1 commit into from
Sep 19, 2022

Conversation

sachintiptur
Copy link
Contributor

Signed-off-by: Sachin Tiptur [email protected]

What this PR does / why we need it:
IPv6 interface configuration was not proper and config files were flooded in failure scenarios. This PR fixes this bug
and Configures/enables IPv6 address for the interface in case of RHEL and RockyLinux which uses NetworkManager.
Which issue(s) this PR fixes:

Fixes #10871

What type of PR is this?

Special notes for your reviewer:
Manual tests and KKP CI dual stack e2e tests are done.
Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

@sachintiptur sachintiptur added the kind/bug Categorizes issue or PR as related to a bug. label Sep 13, 2022
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/osm Denotes a PR or issue as being assigned to SIG OSM. labels Sep 13, 2022
@kubermatic-bot kubermatic-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 13, 2022
@sachintiptur
Copy link
Contributor Author

/retest

@sachintiptur
Copy link
Contributor Author

/retest-required

@rastislavs
Copy link

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0c23e99f5d91d9002a08616f99688fee971d5b84

@sachintiptur
Copy link
Contributor Author

/retest

@ahmedwaleedmalik ahmedwaleedmalik self-requested a review September 14, 2022 07:45
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2022
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 790de2240a7bc02f3a59c4870e325f2f2517188f

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, sachintiptur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2022
@ahmedwaleedmalik
Copy link
Member

/hold

Our vSphere setup is inaccessible directly over the internet at the moment. pull-machine-controller-e2e-vsphere will fail till it's back up.

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2022
@ahmedwaleedmalik
Copy link
Member

/test pull-machine-controller-e2e-vsphere

@ahmedwaleedmalik
Copy link
Member

/unhold
/retest

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2022
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@ahmedwaleedmalik
Copy link
Member

/retest

@kubermatic-bot kubermatic-bot merged commit 59d0e37 into kubermatic:master Sep 19, 2022
@ahmedwaleedmalik
Copy link
Member

/cherrypick release/v1.54

@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: cannot checkout release/v1.54: error checking out release/v1.54: exit status 1. output: error: pathspec 'release/v1.54' did not match any file(s) known to git

In response to this:

/cherrypick release/v1.54

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahmedwaleedmalik
Copy link
Member

/cherrypick release/v1.54

@kubermatic-bot kubermatic-bot mentioned this pull request Sep 26, 2022
Merged
@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: new pull request created: #1442

In response to this:

/cherrypick release/v1.54

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

@rastislavs rastislavs Awaiting requested review from rastislavs

Assignees

@rastislavs rastislavs

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sachintiptur @rastislavs @kubermatic-bot @ahmedwaleedmalik @kubermatic-triage-bot