Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.42] improve kubeconfig/gcp handling of credentials in e2e tests (#1404) #1407

Merged
merged 1 commit into from
Aug 15, 2022
Merged

[release/v1.42] improve kubeconfig/gcp handling of credentials in e2e tests (#1404) #1407

merged 1 commit into from
Aug 15, 2022

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Aug 15, 2022

What this PR does / why we need it:
This is a manual backport of #1404.

/kind cleanup

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 15, 2022
@xrstf xrstf requested a review from ahmedwaleedmalik August 15, 2022 12:36
@xrstf
Copy link
Contributor Author

xrstf commented Aug 15, 2022

/override pull-machine-controller-e2e-openstack
/override pull-machine-controller-e2e-openstack-project-auth
/override pull-machine-controller-e2e-ubuntu-upgrade

@kubermatic-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-openstack, pull-machine-controller-e2e-openstack-project-auth, pull-machine-controller-e2e-ubuntu-upgrade

In response to this:

/override pull-machine-controller-e2e-openstack
/override pull-machine-controller-e2e-openstack-project-auth
/override pull-machine-controller-e2e-ubuntu-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahmedwaleedmalik
Copy link
Member

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2022
@ahmedwaleedmalik
Copy link
Member

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 09cc2fb3e6265712ec96972661cd1b90ea515a51

@kubermatic-bot kubermatic-bot merged commit 7cf528b into kubermatic:release/v1.42 Aug 15, 2022
@xrstf xrstf deleted the backport-1404-1.42 branch August 15, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik Awaiting requested review from ahmedwaleedmalik

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xrstf @kubermatic-bot @ahmedwaleedmalik