Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: be consistent with VMware Cloud Director naming #1321

Merged
merged 1 commit into from
Jun 3, 2022
Merged

refactor: be consistent with VMware Cloud Director naming #1321

merged 1 commit into from
Jun 3, 2022

Conversation

ahmedwaleedmalik
Copy link
Member

Signed-off-by: Waleed Malik [email protected]

What this PR does / why we need it:
We shouldn't call it vcloud since it's the old name.

Which issue(s) this PR fixes (optional, in fixes #<issue number> format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Optional Release Note:

NONE

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jun 3, 2022
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Jun 3, 2022
@kubermatic-bot kubermatic-bot added sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/osm Denotes a PR or issue as being assigned to SIG OSM. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 3, 2022
@ahmedwaleedmalik ahmedwaleedmalik requested a review from kron4eg June 3, 2022 13:01
@kubermatic-bot kubermatic-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 3, 2022
@ahmedwaleedmalik
Copy link
Member Author

/retest

1 similar comment
@ahmedwaleedmalik
Copy link
Member Author

/retest

@kron4eg
Copy link
Member

kron4eg commented Jun 3, 2022

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a392d8e3f9a9bf58553d5dc8f8abde32fd0fbad0

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit ea883ec into kubermatic:master Jun 3, 2022
@ahmedwaleedmalik ahmedwaleedmalik deleted the update-vcd branch June 3, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg Awaiting requested review from kron4eg

Assignees

@kron4eg kron4eg

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmedwaleedmalik @kron4eg @kubermatic-bot