Remove daemon check to ping pod gw #734
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a pod who doesnt need networking ability, current implement will block pod from creating.
halfcrazy
force-pushed
the
feat/disable-ping-check
branch
from
ffa0efd to
4de7bec
Compare
|
The reason to add the ping check is that some pods will try to connect other services immediately after start and if the network is not ready it will trap into crash loop. Similarly issues here #732. And this check can expose some underly issues in early stage instead of ignoring it silently. If the network is not required for the Pod I prefer to add an annotation to bypaas the check. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a pod that doesn't need networking ability, the current implementation will block
pod from creating.
And other CNI doesn't perform such checks.