fix: kube-ovn-controller cannot be ready when ENABLE_METRICS is false #4886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12543295303Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
bobz965
reviewed
Dec 30, 2024
dosubot
bot
added
size:L
Signed-off-by: zhaocongqi <[email protected]>
Signed-off-by: zhaocongqi <[email protected]>
Signed-off-by: zhaocongqi <[email protected]>
Signed-off-by: zhaocongqi <[email protected]>
zhaocongqi
force-pushed
the
fix-metrics
branch
from
ed19cf4 to
4f1463c
Compare
Signed-off-by: zhaocongqi <[email protected]>
zhangzujian
reviewed
Jan 2, 2025
| util.LogFatalAndExit(err, "failed to listen on %s", util.JoinHostPort(metricsAddr, config.PprofPort)) | ||
| } | ||
| svr := manager.Server{ | ||
| Name: "metrics", |
There was a problem hiding this comment.
Suggested change
| Name: "metrics", | |
| Name: "health-check", |
zhangzujian
reviewed
Jan 2, 2025
Comment on lines
+102
to
+107
| Server: &http.Server{ | ||
| Handler: http.NewServeMux(), | ||
| MaxHeaderBytes: 1 << 20, | ||
| IdleTimeout: 90 * time.Second, | ||
| ReadHeaderTimeout: 32 * time.Second, | ||
| }, |
There was a problem hiding this comment.
We need to serve TLS when config.SecureServing is true, or do not use TLS in heclth check when metrics is disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #4862