fix issue 4803: The two names should have a containment relationship #4807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: liwenjian <[email protected]>
dosubot
bot
added
size:XS
Pull Request Test Coverage Report for Build 12248656302Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
oilbeater
requested changes
Dec 10, 2024
pkg/webhook/static_ip.go
Outdated
| if name == ipCR.Spec.PodName { | ||
| // The IP's spec podName does not equal the Pod name in the request; | ||
| // The two names have a containment relationship. | ||
| if strings.Contains(ipCR.Spec.PodName, name) { |
There was a problem hiding this comment.
We need to check ipCR.Spec.PodType first to make sure it's a vm type.
Signed-off-by: liwenjian <[email protected]>
oilbeater
approved these changes
Dec 10, 2024
|
Thanks! @QEDQCD |
zhangzujian
pushed a commit
that referenced
this pull request
Dec 11, 2024
…4807) * fix issue 4803: The two names should have a containment relationship Signed-off-by: liwenjian <[email protected]> * fix issue 4803: The two names should have a containment relationship Signed-off-by: liwenjian <[email protected]> --------- Signed-off-by: liwenjian <[email protected]> Co-authored-by: liwenjian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #(4803)