[bugfix] Optimize gc method at port group and node #4722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
|
@bobz965 @oilbeater please review my code |
zbb88888
requested changes
Nov 12, 2024
pkg/controller/gc.go
Outdated
| @@ -249,11 +249,21 @@ func (c *Controller) gcNode() error { | |||
| klog.Errorf("failed to list logical router policies on lr %s: %v", c.config.ClusterRouter, err) | |||
| return err | |||
| } | |||
| gatewatyRouterPolicies, err := c.OVNNbClient.ListLogicalRouterPolicies(c.config.ClusterRouter, util.GatewayRouterPolicyPriority, map[string]string{"vendor": util.CniTypeName}, false) | |||
There was a problem hiding this comment.
wrong name gatewatyRouterPolicies --> gatewayRouterPolicies
zbb88888
approved these changes
Nov 12, 2024
Signed-off-by: cmdy <[email protected]>
Signed-off-by: cmdy <[email protected]>
Signed-off-by: cmdy <[email protected]>
oilbeater
approved these changes
Nov 13, 2024
oilbeater
pushed a commit
that referenced
this pull request
Nov 13, 2024
* [bugfix] Optimize gc method at port group and node Signed-off-by: cmdy <[email protected]> * skip the centralized subnet policy Signed-off-by: cmdy <[email protected]> * fix gatewayRouterPolicies spelling error Signed-off-by: cmdy <[email protected]> --------- Signed-off-by: cmdy <[email protected]>
oilbeater
pushed a commit
that referenced
this pull request
Nov 14, 2024
* [bugfix] Optimize gc method at port group and node Signed-off-by: cmdy <[email protected]> * skip the centralized subnet policy Signed-off-by: cmdy <[email protected]> * fix gatewayRouterPolicies spelling error Signed-off-by: cmdy <[email protected]> --------- Signed-off-by: cmdy <[email protected]> Signed-off-by: oilbeater <[email protected]>
zbb88888
pushed a commit
that referenced
this pull request
Dec 4, 2024
* [bugfix] Optimize gc method at port group and node Signed-off-by: cmdy <[email protected]> * skip the centralized subnet policy Signed-off-by: cmdy <[email protected]> * fix gatewayRouterPolicies spelling error Signed-off-by: cmdy <[email protected]> --------- Signed-off-by: cmdy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
#4694
#4714