-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow setting default subnet for custom vpc #4171
feat: allow setting default subnet for custom vpc #4171
Conversation
/retest |
the crd yamls should be updated too |
right, do you have maybe a make target or script to generate this? |
maybe later, |
7f7b676
to
7166eeb
Compare
ptal @bobz965 |
c582bdf
to
d512d5f
Compare
PR updated @bobz965 PTAL at your convienience |
@oilbeater could you please help review? |
I think we do not need another annotation for namespace, add the |
Signed-off-by: Karol Szwaj <[email protected]>
Signed-off-by: Karol Szwaj <[email protected]>
Signed-off-by: Karol Szwaj <[email protected]>
Signed-off-by: Karol Szwaj <[email protected]>
Signed-off-by: Karol Szwaj <[email protected]>
Signed-off-by: Karol Szwaj <[email protected]>
Signed-off-by: Karol Szwaj <[email protected]>
Signed-off-by: Karol Szwaj <[email protected]>
@oilbeater @bobz965 thanks for the review |
Signed-off-by: Karol Szwaj <[email protected]>
f28cbaf
to
bcf37b6
Compare
Signed-off-by: Karol Szwaj <[email protected]>
please add some doc about the vpc spec, and clarify the usage details between |
Thanks @bobz965, I will add the docs PR asap |
Signed-off-by: Karol Szwaj <[email protected]>
PTAL @oilbeater |
@cnvergence Thanks for your contribution! |
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #4172