Fix: Resolve issue with skipped execution of sg annotations #3700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wfnuser
force-pushed
the
fix/kubevirt-security-group-annotation
branch
2 times, most recently
from
f3d438d to
d242555
Compare
wfnuser
changed the title
wfnuser
changed the title
|
It's a draft pr.
|
bobz965
requested changes
Feb 6, 2024
|
wfnuser
force-pushed
the
fix/kubevirt-security-group-annotation
branch
from
d242555 to
c184810
Compare
a180285
reviewed
Feb 7, 2024
a180285
reviewed
Feb 7, 2024
| } else { | ||
| sgList := strings.Split(securityGroups, ",") | ||
| if _, err := c.SetLogicalSwitchPortSecurityGroup(lsp, "add", sgList...); err != nil { | ||
| klog.Errorf("set logical switch port %s security groups %s: %v", lsp.Name, securityGroups, err) |
There was a problem hiding this comment.
The code has been updated to another style.
wfnuser
force-pushed
the
fix/kubevirt-security-group-annotation
branch
from
c184810 to
dc210d5
Compare
bobz965
reviewed
Feb 18, 2024
bobz965
force-pushed
the
fix/kubevirt-security-group-annotation
branch
from
dc210d5 to
e36a9c7
Compare
|
There are lint issues should be fixed |
wfnuser
force-pushed
the
fix/kubevirt-security-group-annotation
branch
from
e36a9c7 to
34d363d
Compare
Happy Chinese new year! I just returned to my apartment in BJ. Updated. |
bobz965
approved these changes
Feb 18, 2024
The problem causing ineffective application of sg annotations is that, during virtual machine restart, the logical switch port is intentionally not deleted.(I guess). When sg annotations are added and the VM is restarted, the create logical switch port logic is skipped as it detects the existing lsp. Consequently, the annotation fails to attach to the lsp. Even when we sync lsp for sg, it has no effect. A simple fix is to update the existing lsp during lsp creation if it already exists. This approach ensures correct annotation attachment and addresses the skipped execution issue. Signed-off-by: wfnuser <[email protected]>
bobz965
force-pushed
the
fix/kubevirt-security-group-annotation
branch
from
34d363d to
41bfe81
Compare
oilbeater
approved these changes
Feb 18, 2024
|
@wfnuser Thanks! |
bobz965
pushed a commit
that referenced
this pull request
Feb 18, 2024
The problem causing ineffective application of sg annotations is that, during virtual machine restart, the logical switch port is intentionally not deleted.(I guess). When sg annotations are added and the VM is restarted, the create logical switch port logic is skipped as it detects the existing lsp. Consequently, the annotation fails to attach to the lsp. Even when we sync lsp for sg, it has no effect. A simple fix is to update the existing lsp during lsp creation if it already exists. This approach ensures correct annotation attachment and addresses the skipped execution issue. Signed-off-by: wfnuser <[email protected]>
bobz965
pushed a commit
that referenced
this pull request
Feb 18, 2024
The problem causing ineffective application of sg annotations is that, during virtual machine restart, the logical switch port is intentionally not deleted.(I guess). When sg annotations are added and the VM is restarted, the create logical switch port logic is skipped as it detects the existing lsp. Consequently, the annotation fails to attach to the lsp. Even when we sync lsp for sg, it has no effect. A simple fix is to update the existing lsp during lsp creation if it already exists. This approach ensures correct annotation attachment and addresses the skipped execution issue. Signed-off-by: wfnuser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem causing ineffective application of sg annotations is that, during virtual machine restart, the logical switch port is intentionally not deleted.(I guess).
When sg annotations are added and the VM is restarted, the create logical switch port logic is skipped as it detects the existing lsp. Consequently, the annotation fails to attach to the lsp. Even when we sync lsp for sg, it has no effect.
A simple fix is to update the existing lsp during lsp creation if it already exists. This approach ensures correct annotation attachment and addresses the skipped execution issue.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #3581