Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chart: fix parsing image tag when the image url contains a port #3644

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

zhangzujian
Copy link
Member

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

Fixes #(issue-number)

WHAT

copilot:summary

copilot:poem

HOW

copilot:walkthrough

@zhangzujian zhangzujian added bug Something isn't working need backport chart Helm Chart labels Jan 19, 2024
@zhangzujian zhangzujian force-pushed the fix-chart branch 2 times, most recently from 1ed3e9e to 51ad5b5 Compare January 19, 2024 02:35
@zhangzujian zhangzujian marked this pull request as ready for review January 19, 2024 03:03
@zhangzujian zhangzujian requested a review from oilbeater January 19, 2024 03:03
@zhangzujian zhangzujian merged commit d4a815d into kubeovn:master Jan 22, 2024
60 checks passed
@zhangzujian zhangzujian deleted the fix-chart branch January 22, 2024 03:02
zhangzujian added a commit that referenced this pull request Jan 22, 2024
* chart: fix parsing image tag when the image url contains a port

* chart: handle image tag which is a non-semantic version

---------

Signed-off-by: zhangzujian <[email protected]>
bobz965 pushed a commit that referenced this pull request Jan 23, 2024
* chart: fix parsing image tag when the image url contains a port

* chart: handle image tag which is a non-semantic version

---------

Signed-off-by: zhangzujian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chart Helm Chart need backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants