update policy route when subnet cidr is changed #3587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongzhen-ma
force-pushed
the
policyroute
branch
from
4b595fa to
0b1c6a7
Compare
oilbeater
requested changes
Jan 2, 2024
hongzhen-ma
force-pushed
the
policyroute
branch
from
0b1c6a7 to
076d09f
Compare
oilbeater
requested changes
Jan 2, 2024
pkg/controller/subnet.go
Outdated
| @@ -2957,3 +2968,67 @@ func (c *Controller) clearOldU2OResource(subnet *kubeovnv1.Subnet) error { | |||
| } | |||
| return nil | |||
| } | |||
|
|
|||
| func (c *Controller) checkAndDeleteUnusedPolicyRouteForSubnet(subnet *kubeovnv1.Subnet, isCommonRoute bool) error { | |||
There was a problem hiding this comment.
对于每个子网，创建后都会添加一条 ip4.dst == subnet.spec.Cidr 或者 ip6.dst == subnet.spec.Cidr，优先级为 31000，action 为 allow 的策略路由，这条路由在添加的时候，调用的function 为 addCommonRoutesForSubnet，所以认为这条路由是 commonPolicyRoute
另外，还会根据子网是 分布式或者集中式，分布式添加 ip4.src == subnet.node portgroup 29000 allow 的路由，集中式添加 ip4.src == subnet.spec.cidr 29000 allow 的路由，这两条路由是和具体子网类型相关的，不是每个子网都添加一样的策略路由，所以这两条认为是 非commonRoute 的路由
zbb88888
reviewed
Jan 3, 2024
Signed-off-by: 马洪贞 <[email protected]>
hongzhen-ma
force-pushed
the
policyroute
branch
from
076d09f to
82e60c6
Compare
oilbeater
approved these changes
Jan 4, 2024
hongzhen-ma
added a commit
that referenced
this pull request
Jan 4, 2024
Signed-off-by: 马洪贞 <[email protected]>
zbb88888
pushed a commit
that referenced
this pull request
Jan 5, 2024
Signed-off-by: 马洪贞 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Which issue(s) this PR fixes
Fixes #(issue-number)
WHAT
copilot:summary
copilot:poem
HOW
copilot:walkthrough