fix: ipam clean all pod nic ip address and mac even if just delete a nic #3453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bobz965 <[email protected]>
Signed-off-by: bobz965 <[email protected]>
zbb88888
force-pushed
the
fix-ipam-clean-only-one-pod-nic
branch
from
d195108 to
e6f1d32
Compare
Signed-off-by: bobz965 <[email protected]>
|
@oilbeater 这个之前1.11的已经合入了，已经review 过了 |
zbb88888
added a commit
that referenced
this pull request
Dec 1, 2023
…nic (#3453) * fix: ipam clean all pod nic ip address and mac even if just delete a nic --------- Signed-off-by: bobz965 <[email protected]>
zbb88888
added a commit
that referenced
this pull request
Dec 6, 2023
…nic (#3453) * fix: ipam clean all pod nic ip address and mac even if just delete a nic --------- Signed-off-by: bobz965 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
解决 vm pod 换一张网卡的时候会把所有 ip 释放的问题
Which issue(s) this PR fixes
Fixes #(issue-number)
WHAT
🤖[deprecated] Generated by Copilot at c33b81e
This pull request improves the IPAM module by modifying the
ReleaseAddressByPodfunction and its callers to handle different scenarios of subnet change and pod deletion. It also refactors and fixes some logic in the iptables EIP and OVN EIP controllers, and updates the test and benchmark code accordingly. The changes enhance the performance, correctness, and logging of the IPAM and EIP features.🤖[deprecated] Generated by Copilot at c33b81e
HOW
🤖[deprecated] Generated by Copilot at c33b81e
ReleaseAddressByPodfunction in the IPAM package to release the IP address only from the specified subnet if it is not empty, or from all the subnets if it is empty (link)ReleaseAddressByPodfunction to pass the subnet name as a parameter, and add log messages where appropriate (link, link, link, link, link, link, link, link, link, link)handleDelIptablesEipfunction, and check if the iptables EIP CR exists before deleting it (link, link)ReleaseAddressByPodfunction by passing an empty string as the subnet name (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)