chart: move CRD into directory crds #3420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhangzujian <[email protected]>
oilbeater
approved these changes
Nov 15, 2023
bobz965
pushed a commit
that referenced
this pull request
Nov 17, 2023
Signed-off-by: zhangzujian <[email protected]>
zhangzujian
added a commit
to zhangzujian/kube-ovn
that referenced
this pull request
Jan 9, 2024
This reverts commit 62b0e21.
zhangzujian
added a commit
to zhangzujian/kube-ovn
that referenced
this pull request
Jan 9, 2024
This reverts commit 62b0e21.
zhangzujian
added a commit
to zhangzujian/kube-ovn
that referenced
this pull request
Jan 9, 2024
This reverts commit 62b0e21. Signed-off-by: zhangzujian <[email protected]>
zhangzujian
added a commit
that referenced
this pull request
Jan 11, 2024
* Revert "chart: move CRD into directory crds (#3420)" This reverts commit 62b0e21. Signed-off-by: zhangzujian <[email protected]> * chart: fix ovs-ovn upgrade Signed-off-by: zhangzujian <[email protected]> --------- Signed-off-by: zhangzujian <[email protected]>
bobz965
pushed a commit
that referenced
this pull request
Jan 11, 2024
* Revert "chart: move CRD into directory crds (#3420)" This reverts commit 62b0e21. Signed-off-by: zhangzujian <[email protected]> * chart: fix ovs-ovn upgrade Signed-off-by: zhangzujian <[email protected]> --------- Signed-off-by: zhangzujian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
https://helm.sh/docs/chart_best_practices/custom_resource_definitions/
With the arrival of Helm 3, we removed the old crd-install hooks for a more simple methodology. There is now a special directory called crds that you can create in your chart to hold your CRDs.WHAT
🤖 Generated by Copilot at cc0c7de
Move CRD definition to a separate directory and update references. This improves the chart structure and compatibility with Helm 3.
🤖 Generated by Copilot at cc0c7de
HOW
🤖 Generated by Copilot at cc0c7de
charts/templates/kube-ovn-crd.yamltocharts/crds/crd.yamlto follow the Helm 3 convention for custom resource definitions (link)