delete check for existing ip cr #3361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 马洪贞 <[email protected]>
zhangzujian
approved these changes
Nov 3, 2023
hongzhen-ma
added a commit
that referenced
this pull request
Nov 6, 2023
Signed-off-by: 马洪贞 <[email protected]>
hongzhen-ma
added a commit
that referenced
this pull request
Nov 6, 2023
Signed-off-by: 马洪贞 <[email protected]>
zbb88888
pushed a commit
that referenced
this pull request
Nov 6, 2023
Signed-off-by: 马洪贞 <[email protected]>
hongzhen-ma
added a commit
that referenced
this pull request
Nov 6, 2023
Signed-off-by: 马洪贞 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Which issue(s) this PR fixes:
Fixes #3360
WHAT
🤖 Generated by Copilot at b065572
This pull request simplifies and refactors the IP address management code in
pkg/controller. It removes unused or redundant parameters and variables, and improves the readability and consistency of thecreateOrUpdateCrdIPsfunction.🤖 Generated by Copilot at b065572
HOW
🤖 Generated by Copilot at b065572
createOrUpdateCrdIPsfunction by removing theipCRandexistingCRparameters, which are always nil or unused in most cases (link, link, link, link, link)createOrUpdateCrdIPsfunction fromnode.gotoinit.go, where it belongs with the common functions and constants for the controller package (link)InitIPAMfunction, which is used to initialize the IP address management for pods and nodes, and use the lister directly instead (link)