webhook: fix ip validation when pod is annotated with an ippool name #3284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangzujian
force-pushed
the
fix-webhook
branch
from
3c6f76c to
9a53630
Compare
Signed-off-by: 张祖建 <[email protected]>
zhangzujian
force-pushed
the
fix-webhook
branch
from
9a53630 to
974d716
Compare
oilbeater
approved these changes
Oct 8, 2023
zhangzujian
added a commit
to zhangzujian/kube-ovn
that referenced
this pull request
Oct 9, 2023
zhangzujian
added a commit
that referenced
this pull request
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes:
Fixes #(issue-number)
WHAT
🤖 Generated by Copilot at 3c6f76c
Add IPPool support and improve error handling in
static_ip.gowebhook. This allows users to assign static IPs to pods from predefined IP ranges and enhances the validation of IP conflicts.🤖 Generated by Copilot at 3c6f76c
HOW
🤖 Generated by Copilot at 3c6f76c
ctxparameter tovalidateIPConflictfunction to pass context from webhook request (link, link)k8s.io/apimachinery/pkg/typespackage to useNamespacedNametype for identifying IPPool resources (link)net.ParseIPfunction to return informative message if annotation value is invalid (link)