Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support user custom log location #3186

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Conversation

bobz965
Copy link
Collaborator

@bobz965 bobz965 commented Sep 6, 2023

What type of this PR

support user custom log location

Which issue(s) this PR fixes:

Fixes #(issue-number)

WHAT

🤖 Generated by Copilot at 2d88acc

This pull request adds a new feature to customize the log directory for all the kube-ovn components, either as a helm chart parameter or as an environment variable. It updates the helm chart templates, the yaml files, and the values.yaml file to support this feature. It also enables some flags and settings for the egress IP and IPv6-only features.

🤖 Generated by Copilot at 2d88acc

Sing, O Muse, of the mighty deeds of the kube-ovn team,
Who, with skill and wisdom, forged a helm chart for their scheme,
And gave the users power to set the log directory,
For each container and volume, with a simple variable key.

HOW

🤖 Generated by Copilot at 2d88acc

  • Add a new variable log_conf.LOG_DIR to configure the log directory for all the containers and volumes that use it (link)
  • Replace the hard-coded paths for the host-log-ovs and host-log-ovn volumes with the log_conf.LOG_DIR variable in the central-deploy, controller-deploy, monitor-deploy, ovn-dpdk-ds, and ovncni-ds templates (link, link, link, link, link)
  • Replace the hard-coded paths for the kube-ovn-log volume with the log_conf.LOG_DIR variable in the monitor-deploy template (link)
  • Replace the hard-coded paths for the ovn-controller and ovs-vswitchd containers with the log_conf.LOG_DIR variable in the ovsovn-ds template (link)
  • Replace the hard-coded paths for the kube-ovn-pinger container with the log_conf.LOG_DIR variable in the pinger-ds template (link)
  • Replace the hard-coded paths for the kube-ovn-upgrade-ovs-ovn container with the log_conf.LOG_DIR variable in the upgrade-ovs-ovn template (link)
  • Apply the same changes to the kube-ovn-dual-stack.yaml, kube-ovn-ipv6.yaml, ovn-dpdk.yaml, and ovn-ha.yaml files, which are alternative ways of deploying kube-ovn without using the helm chart (link, link, link, link, link, link, link, link, link, link, link, link, link, link)

@bobz965 bobz965 marked this pull request as ready for review September 6, 2023 03:03
@bobz965 bobz965 requested a review from zhangzujian September 6, 2023 03:03
@bobz965
Copy link
Collaborator Author

bobz965 commented Sep 6, 2023

hi @zhangzujian could you please help review?

@zhangzujian
Copy link
Member

The log directory is also used in other files, such as dist/images/kubectl-ko, dist/images/ovs-healthcheck.sh, and dist/images/start-ic-db.sh.

@bobz965
Copy link
Collaborator Author

bobz965 commented Sep 8, 2023

The log directory is also used in other files, such as dist/images/kubectl-ko, dist/images/ovs-healthcheck.sh, and dist/images/start-ic-db.sh.

是这样的,我们打算只修改 log 目录在 宿主机上的 所在目录,pod 内的路径不需要变动

@bobz965 bobz965 merged commit 11408af into kubeovn:master Sep 8, 2023
@bobz965 bobz965 deleted the cust-log-location branch September 8, 2023 06:02
bobz965 added a commit that referenced this pull request Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants