Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ovn build #3166

Merged
merged 1 commit into from
Sep 6, 2023
Merged

fix ovn build #3166

merged 1 commit into from
Sep 6, 2023

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented Aug 29, 2023

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes:

Fixes #(issue-number)

WHAT

🤖 Generated by Copilot at 32be8b5

Update Windows build workflow to use a new ovn patch. This patch fixes some build errors on Windows by renaming some code to ovs_build_helpers.

🤖 Generated by Copilot at 32be8b5

ovn patch applied
Renaming build helpers
Windows errors fixed

HOW

🤖 Generated by Copilot at 32be8b5

  • Apply a new patch from ovn repository to fix build errors on Windows (link)

@zhangzujian zhangzujian force-pushed the fix-ovn branch 6 times, most recently from deb7e2f to c33b662 Compare August 30, 2023 02:07
@zhangzujian zhangzujian marked this pull request as ready for review August 30, 2023 02:25
@zhangzujian zhangzujian requested review from oilbeater and removed request for oilbeater August 30, 2023 02:25
@zhangzujian zhangzujian marked this pull request as draft August 30, 2023 02:50
@zhangzujian zhangzujian force-pushed the fix-ovn branch 5 times, most recently from 74a2670 to 186ca10 Compare August 31, 2023 06:12
@zhangzujian zhangzujian marked this pull request as ready for review August 31, 2023 06:13
@zhangzujian zhangzujian requested a review from oilbeater August 31, 2023 06:13
@zhangzujian zhangzujian linked an issue Sep 4, 2023 that may be closed by this pull request
Signed-off-by: 张祖建 <[email protected]>
@zhangzujian zhangzujian merged commit d8b06ec into kubeovn:master Sep 6, 2023
@zhangzujian zhangzujian deleted the fix-ovn branch September 6, 2023 05:30
zhangzujian added a commit that referenced this pull request Sep 6, 2023
Signed-off-by: 张祖建 <[email protected]>
zhangzujian added a commit to zhangzujian/kube-ovn that referenced this pull request Sep 6, 2023
zhangzujian added a commit to zhangzujian/kube-ovn that referenced this pull request Sep 6, 2023
@mingoooo
Copy link
Contributor

mingoooo commented Sep 7, 2023

@zhangzujian Hi, I still can not start up northd with this build in my macbook(m2), do you have a same problem?

@zhangzujian
Copy link
Member Author

@zhangzujian Hi, I still can not start up northd with this build in my macbook(m2), do you have a same problem?

What's the error?

@mingoooo
Copy link
Contributor

mingoooo commented Sep 7, 2023

@zhangzujian Hi, I still can not start up northd with this build in my macbook(m2), do you have a same problem?

What's the error?

did not get the error log in northd.log, but also did not find the pid file...

@mingoooo
Copy link
Contributor

mingoooo commented Sep 8, 2023

@zhangzujian Hi, I still can not start up northd with this build in my macbook(m2), do you have a same problem?

What's the error?

did not get the error log in northd.log, but also did not find the pid file...

2023-09-08T02:13:03.231Z|00002|ovn_northd|INFO|OVN internal version is : [22.12.1-20.27.0-70.6]
2023-09-08T02:13:03.231Z|00002|vlog(monitor)|INFO|closing log file
2023-09-08T02:13:03.232Z|00003|reconnect|INFO|tcp:[172.18.0.3]:6641: connecting...
2023-09-08T02:13:03.232Z|00004|reconnect|INFO|tcp:[172.18.0.3]:6641: connected
2023-09-08T02:13:03.232Z|00005|ovn_northd|INFO|OVN NB IDL reconnected, force recompute.
2023-09-08T02:13:03.232Z|00006|reconnect|INFO|tcp:[172.18.0.3]:6642: connecting...
2023-09-08T02:13:03.232Z|00007|reconnect|INFO|tcp:[172.18.0.3]:6642: connected
2023-09-08T02:13:03.232Z|00008|ovn_northd|INFO|OVN SB IDL reconnected, force recompute.
2023-09-08T02:13:03.233Z|00009|ovn_northd|INFO|ovn-northd lock acquired. This ovn-northd instance is now active.
2023-09-08T02:13:13.238Z|00010|memory|INFO|8596 kB peak resident set size after 10.0 seconds

from ovn-northd.log

@mingoooo
Copy link
Contributor

mingoooo commented Sep 8, 2023

FYI, all fine in amd64, not sure the cause...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

base image build failed
2 participants