Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubectl ko diagnose perf release 1.11 #2967

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

changluyi
Copy link
Collaborator

@changluyi changluyi commented Jun 19, 2023

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes:

Fixes #(issue-number)

WHAT

🤖 Generated by Copilot at dcf885a

This pull request adds TCP and UDP connectivity checks between nodes and pods in the cluster as a new feature to improve network diagnostics and metrics. It introduces new flags and configuration fields to the daemon, pinger, and util packages, and modifies the cniserver and pinger packages to start TCP and UDP listeners and perform the checks using the util package functions. It also updates the pinger package functions to ping nodes and pods using TCP and UDP protocols.

🤖 Generated by Copilot at dcf885a

cniserver, pinger
Check TCP and UDP ports
Winter network woes

HOW

🤖 Generated by Copilot at dcf885a

  • Add TCP and UDP connectivity checks between nodes and pods in the cluster (link, link, link, link, link)
  • Add three flags and fields to enable and configure the connectivity checks in the daemon and pinger packages (--enable-verbose-conn-check, --tcp-conn-check-port, --udp-conn-check-port, link, link, link, link, link)
  • Add two goroutines to start TCP and UDP listeners on the specified ports in the cniserver and pinger packages (link, link)
  • Add conditional blocks to perform TCP and UDP connectivity checks to the node and pod IP addresses on the specified ports in the pingNodes and pingPods functions in the pinger package (link, link)
  • Add four functions to implement the logic for the TCP and UDP connectivity checks in the util package (link)
  • Add the time package to the util package to use its functions for setting timeouts and deadlines for the connectivity checks (link)

@changluyi changluyi requested a review from oilbeater June 19, 2023 12:28
@changluyi changluyi merged commit c84a974 into release-1.11 Jun 20, 2023
@changluyi changluyi deleted the kubectl_ko_diagnose_perf_release-1.11 branch June 20, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants