fix: If pod has snat or eip, also delete staticRoute when delete pod. #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oilbeater
requested changes
Jul 22, 2022
pkg/controller/pod.go
Outdated
| @@ -645,6 +645,12 @@ func (c *Controller) handleDeletePod(pod *v1.Pod) error { | |||
| } else if err != nil { | |||
| return err | |||
| } | |||
| // If pod has snat or eip, also need delete staticRoute when delete pod | |||
| if vpc.Name == util.DefaultVpc { | |||
| if err := c.ovnLegacyClient.DeleteStaticRoute(address.Ip, vpc.Status.Router); err != nil { | |||
There was a problem hiding this comment.
Suggested change
| if err := c.ovnLegacyClient.DeleteStaticRoute(address.Ip, vpc.Status.Router); err != nil { | |
| if err := c.ovnLegacyClient.DeleteStaticRoute(address.Ip, vpc.Name); err != nil { |
… pod. Signed-off-by: xujunjie-cover <[email protected]>
oilbeater
approved these changes
Jul 22, 2022
oilbeater
pushed a commit
that referenced
this pull request
Jul 22, 2022
… pod. (#1731) Signed-off-by: xujunjie-cover <[email protected]> (cherry picked from commit ce40f7e)
oilbeater
pushed a commit
that referenced
this pull request
Jul 22, 2022
… pod. (#1731) Signed-off-by: xujunjie-cover <[email protected]> (cherry picked from commit ce40f7e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xujunjie-cover [email protected]
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes:
Fixes #1727