fix: wrong info when update subnet from dual to ipv4 or ipv6. #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xujunjie-cover <[email protected]>
|
Looks good to me. But I am wondering what will happens to the ipam when change subnet protocol |
When change from v4 or v6 to dual，will add v6 or v4 cidr，excludeips to ipam. |
|
Got it. It should be changed later, thanks! |
oilbeater
pushed a commit
that referenced
this pull request
Jul 22, 2022
Signed-off-by: xujunjie-cover <[email protected]> (cherry picked from commit 3c7588b)
oilbeater
pushed a commit
that referenced
this pull request
Jul 22, 2022
Signed-off-by: xujunjie-cover <[email protected]> (cherry picked from commit 3c7588b)
oilbeater
pushed a commit
that referenced
this pull request
Jul 22, 2022
Signed-off-by: xujunjie-cover <[email protected]> (cherry picked from commit 3c7588b)
|
backport down to release-1.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when update subnet from dual to ipv4 or ipv6, available and used ip not correct
What type of this PR
Examples of user facing changes: