fix: sync ovn-ic static route to policy #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oilbeater
requested changes
Jul 8, 2022
pkg/util/const.go
Outdated
Comment on lines
174
to
175
| OVNIC_Key = "origin" | ||
| OVNIC_Value = "connected" |
There was a problem hiding this comment.
OVNIC_Key -> OvnICKey
OVNIC_Value -> OvnICValue
pkg/controller/ovn-ic.go
Outdated
| klog.V(5).Info(" lr ovn-ic route does not exist") | ||
| lrPolicyList, err := c.ovnClient.GetLogicalRouterPoliciesByOptions(util.OVNIC_Key, util.OVNIC_Value) | ||
| if err != nil { | ||
| klog.Warning("failed to list ovn-ic lr policy ", err) |
pkg/controller/ovn-ic.go
Outdated
| return | ||
| } | ||
| for _, lrPolicy := range lrPolicyList { | ||
| err := c.ovnClient.DeleteRouterPolicy(lr, lrPolicy.UUID) |
There was a problem hiding this comment.
if err := xxx; err != nil {}
pkg/controller/ovn-ic.go
Outdated
| for _, lrPolicy := range lrPolicyList { | ||
| err := c.ovnClient.DeleteRouterPolicy(lr, lrPolicy.UUID) | ||
| if err != nil { | ||
| klog.Warningf("deleting router policy failed %v", err) |
| lrPolicy := &ovnnb.LogicalRouterPolicy{ | ||
| Action: action, | ||
| Match: matchfield, | ||
| Options: opts, |
There was a problem hiding this comment.
should set external_ids not options
There was a problem hiding this comment.
external_id is listed here for a complete installation. Actually it is not used.
pkg/controller/ovn-ic.go
Outdated
| policyMap := map[string]string{} | ||
| lrPolicyList, err := c.ovnClient.GetLogicalRouterPoliciesByOptions(util.OVNIC_Key, util.OVNIC_Value) | ||
| if err != nil { | ||
| klog.Warning("failed to list ovn-ic lr policy ", err) |
There was a problem hiding this comment.
all the warning should be replaced with Errorf
pkg/controller/ovn-ic.go
Outdated
| } | ||
| } | ||
| for _, uuid := range policyMap { | ||
| err := c.ovnClient.DeleteRouterPolicy(lr, uuid) |
There was a problem hiding this comment.
if err := xxx; err != nil {}
lut777
force-pushed
the
master
branch
4 times, most recently
from
10d8b91 to
a9a6b55
Compare
oilbeater
approved these changes
Jul 11, 2022
lut777
added a commit
that referenced
this pull request
Jul 12, 2022
lut777
added a commit
that referenced
this pull request
Jul 12, 2022
lut777
added a commit
that referenced
this pull request
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes:
Fixes #1589
interval time of each sync is set to be 5 seconds now. Considering the small number of sync routes, this sync time should not need to be modified.