Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add env-check #1464

Merged
merged 1 commit into from
Apr 24, 2022
Merged

add env-check #1464

merged 1 commit into from
Apr 24, 2022

Conversation

hongzhen-ma
Copy link
Collaborator

What type of this PR

add cmd in plugin to check env

Which issue(s) this PR fixes:

Fixes #1453

@hongzhen-ma hongzhen-ma force-pushed the env-check branch 5 times, most recently from 38427e1 to e7f3ca2 Compare April 22, 2022 07:16
@hongzhen-ma hongzhen-ma requested a review from zhangzujian April 22, 2022 08:30
zhangzujian
zhangzujian reviewed Apr 22, 2022
View reviewed changes
dist/images/install.sh Outdated Show resolved Hide resolved
zhangzujian
zhangzujian reviewed Apr 22, 2022
View reviewed changes
dist/images/install.sh Outdated Show resolved Hide resolved
zhangzujian
zhangzujian reviewed Apr 24, 2022
View reviewed changes
dist/images/install.sh Outdated Show resolved Hide resolved
@hongzhen-ma hongzhen-ma force-pushed the env-check branch 2 times, most recently from 2cedc25 to c732c0a Compare April 24, 2022 06:21
zhangzujian
zhangzujian reviewed Apr 24, 2022
View reviewed changes
dist/images/install.sh Outdated Show resolved Hide resolved
@zhangzujian
Copy link
Member

One more thing, we need to add env-check.sh to the kube-ovn image.

zhangzujian
zhangzujian approved these changes Apr 24, 2022
View reviewed changes
Copy link
Member

@zhangzujian zhangzujian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hongzhen-ma hongzhen-ma added enhancement Improve exist functions need backport labels Apr 24, 2022
@hongzhen-ma hongzhen-ma merged commit abaebea into master Apr 24, 2022
@hongzhen-ma hongzhen-ma deleted the env-check branch April 24, 2022 07:43
hongzhen-ma added a commit that referenced this pull request Apr 24, 2022
@hongzhen-ma
add env-check (#1464)
35ecc68
hongzhen-ma added a commit that referenced this pull request Apr 24, 2022
@hongzhen-ma
add env-check (#1464)
4b012aa
@hongzhen-ma
Copy link
Collaborator Author

已回合release-1.8 和 release-1.9 分支

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangzujian zhangzujian zhangzujian approved these changes

Assignees
No one assigned
Labels
enhancement Improve exist functions need backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Env check for common issues
2 participants
@hongzhen-ma @zhangzujian