When netpol is added to a workload, the workload's POD can be accessed using service #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangzujian
reviewed
Dec 8, 2021
zhangzujian
reviewed
Dec 8, 2021
zhangzujian
reviewed
Dec 8, 2021
zhangzujian
requested changes
Dec 9, 2021
zhangzujian
reviewed
Dec 11, 2021
zhangzujian
reviewed
Dec 11, 2021
zhangzujian
reviewed
Dec 11, 2021
zhangzujian
reviewed
Dec 11, 2021
zhangzujian
reviewed
Dec 11, 2021
|
I noticed that the target branch is Normally we merge PRs to the master branch first and then cherry pick to release branches. Can you create a new PR for the master branch? |
zhangzujian
reviewed
Dec 11, 2021
|
ok i will，bu this pr finally be merged or closed
发自我的iPhone
在 2021年12月11日，14:32，张祖建 ***@***.***> 写道：
I noticed that the target branch is release-1.7 just now.
Normally we merge PRs to the master branch first and then cherry pick to release branches. Can you create a new PR for the master branch?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#1156 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ATMKB7R3USWVRH7V2IVBNN3UQLVV5ANCNFSM5JTBZM3A>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
zhangzujian
approved these changes
Dec 13, 2021
|
Nice work, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d using service
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes:
Fixes #(issue-number)