Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pipelines] Specify KFP SDK version where new caching flag will be available #3881

Merged

Conversation

jgarciao
Copy link
Contributor

As the changes introduced in kubeflow/pipelines#11222 are in master but not in KFP 2.9.0 SDK, modify the Use Caching page to specify when then new caching flag will be available

Copy link

Hi @jgarciao. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Jorge Garcia Oncins <[email protected]>
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbelmiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 090f09b into kubeflow:master Sep 27, 2024
6 checks passed
DharmitD added a commit to DharmitD/website that referenced this pull request Oct 9, 2024
DharmitD added a commit to DharmitD/website that referenced this pull request Oct 9, 2024
DharmitD added a commit to DharmitD/website that referenced this pull request Oct 9, 2024
google-oss-prow bot pushed a commit that referenced this pull request Oct 14, 2024
)

* Revert "[Pipelines] Specify KFP SDK version where new caching flag will be available (#3881)"

This reverts commit 090f09b.

Signed-off-by: ddalvi <[email protected]>

* Revert "[Pipelines] Add doc on disabling default caching flag and env var (#3880)"

This reverts commit 7b7c037.

Signed-off-by: ddalvi <[email protected]>

* Fix enable_caching option's comment typo

Signed-off-by: ddalvi <[email protected]>

---------

Signed-off-by: ddalvi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants