Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluating the Docsy theme - ready for review #303

Merged
merged 65 commits into from
Jan 3, 2019
Merged

Evaluating the Docsy theme - ready for review #303

merged 65 commits into from
Jan 3, 2019

Conversation

sarahmaddox
Copy link
Contributor

@sarahmaddox sarahmaddox commented Nov 23, 2018 •
edited by jlewi
Loading

This change is Reviewable

sarahmaddox and others added 10 commits November 14, 2018 07:07
@sarahmaddox
Initial commit of Docsy theme.
940a461
@sarahmaddox
Moved Docsy to the themes directory.
4f9501d
@sarahmaddox
Updated theme config and shortcodes for Docsy theme.
2edc7d2
@sarahmaddox
Fixed order of TOML entries - tables must go last.
72de12d
@sarahmaddox @bep
Ad nil checks for menus and footer links
d289d5b 
This commit also bumps `netlify.toml` to a newer Hugo version, as variable overwrites needs Go 1.11. It can be made to work with older Hugo's, but ...

See gohugoio/hugo#5461
@LisaFC
Fix duplicated params definition
810c071
@sarahmaddox
Merge pull request #1 from LisaFC/patch-1
7f27714 
Fix duplicated params definition
@sarahmaddox
Merge branch 'master' of https://github.com/kubeflow/website into docsy
d9412c1
@sarahmaddox
Pull updated config from GitHub after merging pull request on GitHub UI.
c25388f
@sarahmaddox
Merge branch 'nil-fixes' of https://github.com/bep/website-2 into docsy
595354b
@sarahmaddox
Copy link
Contributor Author

Removing reviewers because this PR will be noisy until I've finished adding commits.

/uncc @jlewi
/uncc @kunmingg

@sarahmaddox
Copy link
Contributor Author

Fixes issue #291

@sarahmaddox
Check in JS resources as workaround to Netlify build issue kubeflow#182…
ef74793 
… (unable to build from Hugo extended version).
@sarahmaddox sarahmaddox mentioned this pull request Nov 27, 2018
Closed
@sarahmaddox sarahmaddox changed the title WIP Trying the Docsy theme Evaluating the Docsy theme - ready for review Dec 25, 2018
@sarahmaddox
Copy link
Contributor Author

/assign @abhi-g
/cc @jlewi
/cc @pdmack

Preview:

I'm sure there's some tidying up we can do, such as refining the CSS and styling in general, but I'm hoping this version is good enough to submit and then refine if needed. Also, when we have the theme in place, we can work on adding extras like search and Google Analytics - the hooks are in the theme, we just need to add the specifics.

Comments welcome.

@k8s-ci-robot k8s-ci-robot requested review from jlewi and pdmack December 25, 2018 02:52
@sarahmaddox
Copy link
Contributor Author

/fixed #322
/fixed #305
/fixed #264
/fixed #124

@jlewi
Copy link
Contributor

jlewi commented Dec 28, 2018

This looks great.

I really like the links to edit this page and file an issue.

/lgtm
/approve
/hold

I put the hold on just in case you want others to review before submitting. If not just remove it.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sarahmaddox
Copy link
Contributor Author

Thanks @jlewi! I'll give it a couple of days, in case anyone else wants to take a look.

@gaocegege
Copy link
Member

The new website preview looks awesome! 🎉

@sarahmaddox
Copy link
Contributor Author

/fixed #355

@sarahmaddox
Copy link
Contributor Author

/hold cancel

@sarahmaddox
Copy link
Contributor Author

/retest

@jlewi
Copy link
Contributor

jlewi commented Jan 3, 2019

/cancel hold

@jlewi
Copy link
Contributor

jlewi commented Jan 3, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit a1d1521 into kubeflow:master Jan 3, 2019
@sarahmaddox sarahmaddox mentioned this pull request Jan 4, 2019
Closed
@nareshganesan
Copy link

Both the content and the UX of the new documenation looks great 👍

@sarahmaddox sarahmaddox deleted the docsy branch January 25, 2019 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlewi jlewi Awaiting requested review from jlewi

@pdmack pdmack Awaiting requested review from pdmack

Assignees

@jlewi jlewi

@abhi-g abhi-g

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sarahmaddox @jlewi @k8s-ci-robot @gaocegege @nareshganesan @abhi-g @LisaFC