Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Istio usage in Kubeflow #1648

Merged
merged 9 commits into from
Feb 12, 2020
Merged

Istio usage in Kubeflow #1648

merged 9 commits into from
Feb 12, 2020

Conversation

abhi-g
Copy link
Member

@abhi-g abhi-g commented Feb 11, 2020

Provide a high level introduction to Istio and how it is used in Kubeflow.

#fixes #1532

See preview https://deploy-preview-1648--competent-brattain-de2d6d.netlify.com/docs/other-guides/istio-in-kubeflow/


This change is Reviewable

@abhi-g abhi-g changed the title WIP:Istio usage in Kubeflow Istio usage in Kubeflow Feb 11, 2020
@abhi-g
Copy link
Member Author

abhi-g commented Feb 11, 2020

/test kubeflow-website-presubmit

Copy link
Contributor

@kunmingg kunmingg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the picture shall we rename notebooks to notebook controller?
And other controllers as well?

@sarahmaddox
Copy link
Contributor

/cc

Copy link
Contributor

@sarahmaddox sarahmaddox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abhi-g This is a much-needed doc. I've added a few comments to make things clearer for the reader.

@sarahmaddox
Copy link
Contributor

/assign

@abhi-g
Copy link
Member Author

abhi-g commented Feb 12, 2020

@sarahmaddox @kunmingg ready for another look

@sarahmaddox
Copy link
Contributor

Thanks @abhi-g!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sarahmaddox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3ab49b3 into kubeflow:master Feb 12, 2020
@abhi-g abhi-g deleted the istio-kf branch February 12, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain the usage of Istio within Kubeflow
5 participants