-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Istio usage in Kubeflow #1648
Istio usage in Kubeflow #1648
Conversation
/test kubeflow-website-presubmit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the picture shall we rename notebooks
to notebook controller
?
And other controllers as well?
/cc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @abhi-g This is a much-needed doc. I've added a few comments to make things clearer for the reader.
/assign |
@sarahmaddox @kunmingg ready for another look |
Thanks @abhi-g! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sarahmaddox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Provide a high level introduction to Istio and how it is used in Kubeflow.
#fixes #1532
See preview https://deploy-preview-1648--competent-brattain-de2d6d.netlify.com/docs/other-guides/istio-in-kubeflow/
This change is