Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS style for list items - bullet or number appears on last line instead of first line of list item #163

Closed
sarahmaddox opened this issue Aug 15, 2018 · 8 comments
Assignees

Comments

@sarahmaddox
Copy link
Contributor

In a list, the bullet or number often appears on last line of the list item instead of on the first line of the list item

This happens on the blog as well as in the docs.

Blog post: https://www.kubeflow.org/blog/announcing_kubeflow_0.2/
screen shot 2018-08-16 at 8 47 46 am

Doc: https://www.kubeflow.org/docs/started/getting-started-gke/
screen shot 2018-08-16 at 8 49 41 am

The problem seems to depend on spacing in the list: Sometimes you can make the bullet/number appear in the right place by removing all empty lines between list items. But that's not possible if you need code snippets in the list, because the lack of spacing makes the code snippets render as normal text.

@sarahmaddox
Copy link
Contributor Author

/area docs

@sarahmaddox
Copy link
Contributor Author

Another list-related style that needs improving: The styling doesn't handle 3 levels of indent, for example, the markup below renders as a numbered list item, then a bullet list item, then a list item marked by a large rectangular icon:

1. Choose one of the options below to connect to JupyterHub:

    * To connect to JupyterHub using the Kubeflow URL:

        1. Open a web browser and go to your Kubeflow URL.

@sarahmaddox
Copy link
Contributor Author

I've let the designer know about these issues.

@sarahmaddox
Copy link
Contributor Author

/assign

@sarahmaddox
Copy link
Contributor Author

The designer has given us a set of updated CSS styles, which largely fix the first problem - list icons now appear on the first line of a multi-line list in most cases. The fix also fixes the second problem reported on this issue: styling for three levels of indent.

@abhi-g has submitted the designer's fixes in this PR:
#192

@sarahmaddox
Copy link
Contributor Author

sarahmaddox commented Sep 3, 2018

However, the first problem (list icons appearing on last line of multi-line list) still occurs under certain circumstances.

See the section "Improved getting started experience" on this page:
https://master.kubeflow.org/blog/announcing_kubeflow_0.2/

Also under "Using your own domain" here:
https://master.kubeflow.org/docs/started/getting-started-gke/

The problem seems to happen now only when code blocks are interspersed between the list items.

I'll get in touch with the designer again.

@sarahmaddox
Copy link
Contributor Author

I'm closing this issue because we've fixed most of the problem, and issue #355 covers the remaining issue with bullet items.

/close

@k8s-ci-robot
Copy link
Contributor

@sarahmaddox: Closing this issue.

In response to this:

I'm closing this issue because we've fixed most of the problem, and issue #355 covers the remaining issue with bullet items.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants