-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-2170: Deploy JobSet in kubeflow-system
namespace
#2388
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Andrey Velichkevich <[email protected]>
Signed-off-by: Andrey Velichkevich <[email protected]>
Signed-off-by: Andrey Velichkevich <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@andreyvelich: GitHub didn't allow me to request PR reviews from the following users: seanlaii, saileshd1402, astefanutti, kubeflow/release-team, doris-xm, vsoch, kannon92, kubeflow/wg-manifests-leads. Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold for kubernetes-sigs/jobset#751 |
- ../../base/manager | ||
- ../../base/rbac | ||
- ../../base/webhook | ||
- https://github.com/kubernetes-sigs/jobset/releases/download/v0.7.2/manifests.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would that make sense to group the JobSet related resources into a dedicated directory / overlay?
It could make things more modular and accommodate environments where the JobSet API / controller is already installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, we can make it similar to KFP and move it into third-party/jobset/kustomization.yaml
.
So the manifests will looks like this:
/v2/base/...
/v2/overlays/...
/v2/third-party/...
@kubeflow/wg-training-leads WDYT about it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreyvelich SGTM:)
Signed-off-by: Andrey Velichkevich <[email protected]>
1dd0225
to
9fe7112
Compare
Part of: #2170
Depends on: kubernetes-sigs/jobset#751, we should update the JobSet version once this fix is released.
I updated the Kubeflow Training V2 manifests to deploy JobSet in the
kubeflow-system
namespace. Also, given that the Training Runtimes need to be installed after the manager is deployed and is running, I think we should split out overlays between these two:manager
runtimes
/cc @kannon92 @kubeflow/wg-training-leads @kubeflow/wg-manifests-leads @kubeflow/release-team @Electronic-Waste @Doris-xm @astefanutti @seanlaii @deepanker13 @saileshd1402 @vsoch