Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Training SDK 1.9.0 #2395

Merged
merged 1 commit into from
Jan 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hack/python-sdk/gen-sdk.sh
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ SWAGGER_JAR_URL="https://repo1.maven.org/maven2/org/openapitools/openapi-generat
SWAGGER_CODEGEN_JAR="${repo_root}/hack/python-sdk/openapi-generator-cli.jar"
SWAGGER_CODEGEN_CONF="${repo_root}/hack/python-sdk/swagger_config.json"
SDK_OUTPUT_PATH="${repo_root}/sdk/python"
VERSION=1.9.0rc0
VERSION=1.9.0
SWAGGER_CODEGEN_FILE="${repo_root}/hack/python-sdk/swagger.json"

if [ -z "${GOPATH:-}" ]; then
Expand Down
2 changes: 1 addition & 1 deletion hack/python-sdk/swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"info": {
"description": "Python SDK for Kubeflow Training",
"title": "Kubeflow Training SDK",
"version": "v1.9.0rc0"
"version": "v1.9.0"
},
"paths": {},
"definitions": {
Expand Down
2 changes: 1 addition & 1 deletion hack/python-sdk/swagger_config.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"packageName": "kubeflow.training",
"projectName": "training",
"packageVersion": "1.9.0rc0",
"packageVersion": "1.9.0",
"typeMappings": {
"V1Time": "datetime"
}
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/kubeflow/training/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""


from __future__ import absolute_import

__version__ = "1.9.0rc0"
__version__ = "1.9.0"

# import apis into sdk package

Expand Down
4 changes: 2 additions & 2 deletions sdk/python/kubeflow/training/api_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down Expand Up @@ -78,7 +78,7 @@ def __init__(self, configuration=None, header_name=None, header_value=None,
self.default_headers[header_name] = header_value
self.cookie = cookie
# Set default User-Agent.
self.user_agent = 'OpenAPI-Generator/1.9.0rc0/python'
self.user_agent = 'OpenAPI-Generator/1.9.0/python'
self.client_side_validation = configuration.client_side_validation

def __enter__(self):
Expand Down
6 changes: 3 additions & 3 deletions sdk/python/kubeflow/training/configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down Expand Up @@ -324,8 +324,8 @@ def to_debug_report(self):
return "Python SDK Debug Report:\n"\
"OS: {env}\n"\
"Python Version: {pyversion}\n"\
"Version of the API: v1.9.0rc0\n"\
"SDK Package Version: 1.9.0rc0".\
"Version of the API: v1.9.0\n"\
"SDK Package Version: 1.9.0".\
format(env=sys.platform, pyversion=sys.version)

def get_host_settings(self):
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/kubeflow/training/exceptions.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down
2 changes: 1 addition & 1 deletion sdk/python/kubeflow/training/models/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down
2 changes: 1 addition & 1 deletion sdk/python/kubeflow/training/rest.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

Python SDK for Kubeflow Training # noqa: E501

The version of the OpenAPI document: v1.9.0rc0
The version of the OpenAPI document: v1.9.0
Generated by: https://openapi-generator.tech
"""

Expand Down
2 changes: 1 addition & 1 deletion sdk/python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

setuptools.setup(
name="kubeflow-training",
Copy link
Member

@terrytangyuan terrytangyuan Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to resolve https://peps.python.org/pep-0625/?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, your point is wondering if we should rename to "kubeflow_training" or "kubeflowtraining"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, it is fine to keep it for 1.9 SDK since in the Deprecation they say:

 Any source distributions already uploaded will remain in place as-is and do not need to be updated.

For the newer Kubeflow Trainer SDK, we will name it kubeflow.
Does it look good @tenzen-y @terrytangyuan ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

version="1.9.0rc0",
version="1.9.0",
author="Kubeflow Authors",
author_email="[email protected]",
license="Apache License Version 2.0",
Expand Down
Loading