Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(gcp): set up periodic cleanup of pipelineruns for kf-ci-v1. Fixes #750 #814

Merged
merged 5 commits into from
Nov 19, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Nov 19, 2020

Fixes #750
/cc @PatrickXYS
this can be useful for AWS test infra too

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 19, 2020

I'll self approve to quickly verify on GCP test infra

@Bobgy Bobgy added the lgtm label Nov 19, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 19, 2020
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@Bobgy Bobgy added the lgtm label Nov 19, 2020
@k8s-ci-robot
Copy link
Contributor

@Bobgy: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-testing-presubmit 11fd5b8 link /test kubeflow-testing-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 19, 2020

test infra seems flaky, I'll force merge this one

@Bobgy Bobgy merged commit 0ad66c5 into kubeflow:master Nov 19, 2020
@Bobgy Bobgy deleted the cleanup_ci branch November 19, 2020 11:57
@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 19, 2020

I got an error syncing the config:

kf-ci-v1   KNV1039: Cluster-scoped configs except Namespaces MUST be declared in `cluster/`. To fix, move the ClusterRole to `cluster/`.

source: namespaces/cleanup/rbac.authorization.k8s.io_v1_clusterrole_cleanup.yaml
namespace: cleanup
metadata.name: cleanup
group: rbac.authorization.k8s.io
version: v1
kind: ClusterRole

@PatrickXYS
Copy link
Member

Thanks @Bobgy

Looks like Tekton Pipeline doesn't support GC, which requires CronJobs to GC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GC old tekton resources periodically
3 participants