Initial batch of fixes to run E2E notebook tests against blueprint deployments #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ployments.
* Update get_kf_testing_cluster to work with blueprints
* With GCP blueprints we won't have deployments so we need to
list clusters by name and find cluster with matching regex.
* Create an ACM repo for kf-ci-v1 cluster and hydrate it with the appropriate
manifests for the auto-deploy and tektoncd namespaces.
* kubeflow#677 is tracking using ACM with the cluster kf-ci-v1
* Note this PR is only using ACM to sync tekton resources; we still need
to sync the rest of the auto-deployment infrastructure like the reconciler
and webserver.
* Remove ACM cluster selector; ACM complains because it isn't actually being applied.
* Override notebook-test-task.yaml with nb-test-task.yaml. The latter should include the latest changes from Gabriel's PR.
* When deploying the blueprint we need to do `kpt cfg set email` to
set the email for the default profile. Without this change
the deployment won't include the namespace we need to run
the tests in
GoogleCloudPlatform/kubeflow-distribution#42 is tracking CI for the blueprints.
|
This change is |
jlewi
changed the title
|
/assign @Bobgy |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy, jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update get_kf_testing_cluster to work with blueprints
list clusters by name and find cluster with matching regex.
Create an ACM repo for kf-ci-v1 cluster and hydrate it with the appropriate
manifests for the auto-deploy and tektoncd namespaces.
Use ACM to sync Tekton Resources to kf-ci-v1 #677 is tracking using ACM with the cluster kf-ci-v1
Note this PR is only using ACM to sync tekton resources; we still need
to sync the rest of the auto-deployment infrastructure like the reconciler
and webserver.
Remove ACM cluster selector; ACM complains because it isn't actually being applied.
Override notebook-test-task.yaml with nb-test-task.yaml. The latter should include the latest changes from Gabriel's PR.
When deploying the blueprint we need to do
kpt cfg set emailtoset the email for the default profile. Without this change
the deployment won't include the namespace we need to run
the tests in
GoogleCloudPlatform/kubeflow-distribution#42 is tracking CI for the blueprints.