Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v2.1.0 #2354

Merged
merged 14 commits into from
Dec 11, 2024
Merged

Release v2.1.0 #2354

merged 14 commits into from
Dec 11, 2024

Conversation

ChenYi015
Copy link
Contributor

Purpose of this PR

Cherry pick the following commits and release v2.1.0:

Aransh and others added 14 commits December 10, 2024 19:53
@Aransh @ChenYi015
Allow setting automountServiceAccountToken (kubeflow#2298)
e37afbd 
* Allow setting automountServiceAccountToken on workloads and serviceAccounts

Signed-off-by: Aran Shavit <[email protected]>

* update helm docs

Signed-off-by: Aran Shavit <[email protected]>

---------

Signed-off-by: Aran Shavit <[email protected]>
(cherry picked from commit 515d805)
@ChenYi015
Fix: executor container security context does not work (kubeflow#2306)
833ba5c 
Signed-off-by: Yi Chen <[email protected]>
(cherry picked from commit 171e429)
@ChenYi015
Fix: should not add emptyDir sizeLimit conf if it is nil (kubeflow#2305)
ea016d0 
Signed-off-by: Yi Chen <[email protected]>
(cherry picked from commit 763682d)
@npgretz @ChenYi015
Allow the Controller and Webhook Containers to run with the securityC…
0690d25 
…ontext: readOnlyRootfilesystem: true (kubeflow#2282)

* create a tmp dir for the controller to write Spark artifacts to and set the controller to readOnlyRootFilesystem

Signed-off-by: Nick Gretzon <[email protected]>

* mount a dir for the webhook container to generate its certificates in and set readOnlyRootFilesystem: true for the webhook pod

Signed-off-by: Nick Gretzon <[email protected]>

* update the securityContext in the controller deployment test

Signed-off-by: Nick Gretzon <[email protected]>

* update securityContext of the webhook container in the deployment_test

Signed-off-by: Nick Gretzon <[email protected]>

* update README

Signed-off-by: Nick Gretzon <[email protected]>

* remove -- so comments are not rendered in the README.md

Signed-off-by: Nick Gretzon <[email protected]>

* recreate README.md after removal of comments for volumes and volumeMounts

Signed-off-by: Nick Gretzon <[email protected]>

* make indentation for volumes and volumeMounts consistent with rest of values.yaml

Signed-off-by: Nick Gretzon <[email protected]>

* Revert "make indentation for volumes and volumeMounts consistent with rest of values.yaml"

This reverts commit dba97fc.

Signed-off-by: Nick Gretzon <[email protected]>

* fix indentation in webhook and controller deployment templates for volumes and volumeMounts

Signed-off-by: Nick Gretzon <[email protected]>

* Update charts/spark-operator-chart/values.yaml

Co-authored-by: Yi Chen <[email protected]>
Signed-off-by: Nicholas Gretzon <[email protected]>

* Update charts/spark-operator-chart/values.yaml

Co-authored-by: Yi Chen <[email protected]>
Signed-off-by: Nicholas Gretzon <[email protected]>

* Update charts/spark-operator-chart/values.yaml

Co-authored-by: Yi Chen <[email protected]>
Signed-off-by: Nicholas Gretzon <[email protected]>

* Update charts/spark-operator-chart/values.yaml

Co-authored-by: Yi Chen <[email protected]>
Signed-off-by: Nicholas Gretzon <[email protected]>

* Update charts/spark-operator-chart/templates/controller/deployment.yaml

Co-authored-by: Yi Chen <[email protected]>
Signed-off-by: Nicholas Gretzon <[email protected]>

* Update charts/spark-operator-chart/templates/controller/deployment.yaml

Co-authored-by: Yi Chen <[email protected]>
Signed-off-by: Nicholas Gretzon <[email protected]>

* Update charts/spark-operator-chart/templates/webhook/deployment.yaml

Co-authored-by: Yi Chen <[email protected]>
Signed-off-by: Nicholas Gretzon <[email protected]>

* Update charts/spark-operator-chart/templates/webhook/deployment.yaml

Co-authored-by: Yi Chen <[email protected]>
Signed-off-by: Nicholas Gretzon <[email protected]>

* add additional securityContext to the controller deployment_test.yaml

Signed-off-by: Nick Gretzon <[email protected]>

---------

Signed-off-by: Nick Gretzon <[email protected]>
Signed-off-by: Nicholas Gretzon <[email protected]>
Co-authored-by: Yi Chen <[email protected]>
(cherry picked from commit 72107fd)
@Cian911 @ChenYi015
Fix: should not add emptyDir sizeLimit conf on executor pods if it is…
2dbb0ff 
… nil (kubeflow#2316)

Signed-off-by: Cian Gallagher <[email protected]>
(cherry picked from commit 2999546)
@jacobsalway @ChenYi015
Bump volcano.sh/apis to 1.10.0 (kubeflow#2320)
d808b75 
Signed-off-by: Jacob Salway <[email protected]>
(cherry picked from commit 22e4fb8)
@jacobsalway @ChenYi015
Truncate UI service name if over 63 characters (kubeflow#2311)
28d678e 
* Truncate UI service name if over 63 characters

Signed-off-by: Jacob Salway <[email protected]>

* Also truncate ingress name

Signed-off-by: Jacob Salway <[email protected]>

---------

Signed-off-by: Jacob Salway <[email protected]>
(cherry picked from commit 43c1888)
@dependabot @ChenYi015
Bump aquasecurity/trivy-action from 0.28.0 to 0.29.0 (kubeflow#2332)
9683e48 
Bumps [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action) from 0.28.0 to 0.29.0.
- [Release notes](https://github.com/aquasecurity/trivy-action/releases)
- [Commits](aquasecurity/trivy-action@0.28.0...0.29.0)

---
updated-dependencies:
- dependency-name: aquasecurity/trivy-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 270b09e)
@dependabot @ChenYi015
Bump github.com/onsi/ginkgo/v2 from 2.20.2 to 2.22.0 (kubeflow#2335)
fd0b4a5 
Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.20.2 to 2.22.0.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.20.2...v2.22.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 40423d5)
@c-h-afzal @ChenYi015
The webhook-key-name command-line param isn't taking effect (kubeflow…
bfd1228 
…#2344)

Signed-off-by: C. H. Afzal <[email protected]>
(cherry picked from commit a261523)
@Tom-Newton @ChenYi015
Robustness to driver pod taking time to create (kubeflow#2315)
edffd7b 
* Retry after driver pod now found if recent submission

Signed-off-by: Thomas Newton <[email protected]>

* Add a test

Signed-off-by: Thomas Newton <[email protected]>

* Make grace period configurable

Signed-off-by: Thomas Newton <[email protected]>

* Update test

Signed-off-by: Thomas Newton <[email protected]>

* Add an extra test with the driver pod

Signed-off-by: Thomas Newton <[email protected]>

* Separate context to create and delete the driver pod

Signed-off-by: Thomas Newton <[email protected]>

* Tidy

Signed-off-by: Thomas Newton <[email protected]>

* Autoformat

Signed-off-by: Thomas Newton <[email protected]>

* Update error message

Signed-off-by: Thomas Newton <[email protected]>

* Add helm paramater

Signed-off-by: Thomas Newton <[email protected]>

* Update internal/controller/sparkapplication/controller.go

Co-authored-by: Yi Chen <[email protected]>
Signed-off-by: Thomas Newton <[email protected]>

* Newlines between helm tests

Signed-off-by: Thomas Newton <[email protected]>

---------

Signed-off-by: Thomas Newton <[email protected]>
Co-authored-by: Yi Chen <[email protected]>
(cherry picked from commit d815e78)
@Aakcht @ChenYi015
Use NSS_WRAPPER_PASSWD instead of /etc/passwd as in spark-operator im…
d7351d8 
…age entrypoint.sh (kubeflow#2312)

Signed-off-by: Aakcht <[email protected]>
(cherry picked from commit 5dd91c4)
@ChenYi015
Move sparkctl to cmd directory (kubeflow#2347)
b4e653d 
* Move spark-operator

Signed-off-by: Yi Chen <[email protected]>

* Move sparkctl to cmd directory

Signed-off-by: Yi Chen <[email protected]>

* Remove unnecessary app package/directory

Signed-off-by: Yi Chen <[email protected]>

---------

Signed-off-by: Yi Chen <[email protected]>
(cherry picked from commit 2375a30)
@ChenYi015
Spark Operator Official Release v2.1.0
df56f71 
Signed-off-by: Yi Chen <[email protected]>
@ChenYi015
Copy link
Contributor Author

/assign @jacobsalway

jacobsalway
jacobsalway approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@jacobsalway jacobsalway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Dec 11, 2024
@ChenYi015
Copy link
Contributor Author

/approve

@google-oss-prow Google OSS Prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015, jacobsalway

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 664b9d0 into kubeflow:release-2.1 Dec 11, 2024
11 of 12 checks passed
@ChenYi015 ChenYi015 deleted the release-2.1 branch December 11, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobsalway jacobsalway jacobsalway approved these changes

@ImpSy ImpSy Awaiting requested review from ImpSy

Assignees

@jacobsalway jacobsalway

Labels
approved lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ChenYi015 @jacobsalway @Aransh @npgretz @Cian911 @c-h-afzal @Tom-Newton @Aakcht