Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update issue and pull request templates #2287

Merged
merged 4 commits into from
Oct 26, 2024
Merged

Update issue and pull request templates #2287

merged 4 commits into from
Oct 26, 2024

Conversation

ChenYi015
Copy link
Contributor

Proposed changes

  • Update issue and pull request templates

@ChenYi015
Copy link
Contributor Author

/assign @ImpSy @jacobsalway

jacobsalway
jacobsalway approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@jacobsalway jacobsalway left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Not a blocker for approval but some small nitpicks:

  • Referring to the operator as "the Spark operator"
  • We could add links to the Slack as well

@google-oss-prow google-oss-prow bot added the lgtm label Oct 25, 2024
@google-oss-prow google-oss-prow bot removed the lgtm label Oct 25, 2024
@ChenYi015 ChenYi015 requested a review from jacobsalway October 25, 2024 16:24
@ChenYi015
Copy link
Contributor Author

Not a blocker for approval but some small nitpicks:

  • Referring to the operator as "the Spark operator"
  • We could add links to the Slack as well

Done.

jacobsalway
jacobsalway approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@jacobsalway jacobsalway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Oct 25, 2024
@ChenYi015
Copy link
Contributor Author

/approve

@google-oss-prow Google OSS Prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015, jacobsalway

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 85f0ed0 into kubeflow:master Oct 26, 2024
11 checks passed
@ChenYi015 ChenYi015 deleted the issue-template branch October 28, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobsalway jacobsalway jacobsalway approved these changes

@ImpSy ImpSy Awaiting requested review from ImpSy

Assignees

@ImpSy ImpSy

@jacobsalway jacobsalway

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChenYi015 @jacobsalway @ImpSy