Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emptyDir sizeLimit support for local dirs #1993

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

jacobsalway
Copy link
Member

@jacobsalway jacobsalway commented Apr 18, 2024

Purpose of this PR

  • Support the sizeLimit field for emptyDir volume types that are prefixed with spark-local-dir-...

Change Category

Indicate the type of change by marking the applicable boxes:

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Checklist

Before submitting your PR, please review the following:

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

@jacobsalway jacobsalway force-pushed the add-empty-dir-size-limit branch 2 times, most recently from fc1c352 to 113a298 Compare April 18, 2024 10:49
@jacobsalway jacobsalway force-pushed the add-empty-dir-size-limit branch from 113a298 to 73d7469 Compare April 18, 2024 10:51
@jacobsalway jacobsalway marked this pull request as ready for review April 18, 2024 11:00
@google-oss-prow google-oss-prow bot requested a review from vara-bonthu April 18, 2024 11:00
@vara-bonthu
Copy link
Contributor

@jacobsalway, thanks for the PR! It would be great if you could also update the documentation to reflect this new feature. Additionally, please address the failing pre-commit checks.

@jacobsalway jacobsalway force-pushed the add-empty-dir-size-limit branch from a5395c9 to 7c6b770 Compare April 19, 2024 13:01
@jacobsalway
Copy link
Member Author

jacobsalway commented Apr 19, 2024

@vara-bonthu have bumped the app version (thought it only wanted me to bump the chart version but I understand the check now) and added a sizeLimit field to the volume example on the user guide. As an operator user I usually consult the that page and expected this to work by default given that it's supported in the SparkApplication CRD, so I think the example is good enough but happy to add additional docs if you prefer

@jacobsalway jacobsalway changed the title Add emptyDir sizeLimit support Add emptyDir sizeLimit support for local dirs Apr 19, 2024
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobsalway, vara-bonthu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit ccb3ceb into kubeflow:master Apr 19, 2024
7 checks passed
@jacobsalway jacobsalway deleted the add-empty-dir-size-limit branch April 19, 2024 23:11
sigmarkarl pushed a commit to spotinst/spark-on-k8s-operator that referenced this pull request Aug 7, 2024
* Add emptyDir sizeLimit support

Signed-off-by: Jacob Salway <[email protected]>

* Bump appVersion and add sizeLimit example

Signed-off-by: Jacob Salway <[email protected]>

---------

Signed-off-by: Jacob Salway <[email protected]>
jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
* Add emptyDir sizeLimit support

Signed-off-by: Jacob Salway <[email protected]>

* Bump appVersion and add sizeLimit example

Signed-off-by: Jacob Salway <[email protected]>

---------

Signed-off-by: Jacob Salway <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants