Tidy

kubeflow · Nov 10, 2024 · dd39e70 · dd39e70
1 parent ebff2ac
commit dd39e70
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/cmd/operator/controller/start.go b/cmd/operator/controller/start.go
@@ -165,7 +165,7 @@ func NewStartCommand() *cobra.Command {
 	command.Flags().DurationVar(&leaderElectionRenewDeadline, "leader-election-renew-deadline", 14*time.Second, "Leader election renew deadline.")
 	command.Flags().DurationVar(&leaderElectionRetryPeriod, "leader-election-retry-period", 4*time.Second, "Leader election retry period.")
 
-	command.Flags().DurationVar(&driverPodCreationGracePeriod, "driver-pod-creation-grace-period", 10*time.Second, "Grace period after a successful spark-submit when driver pod not found errors will be retried.")
+	command.Flags().DurationVar(&driverPodCreationGracePeriod, "driver-pod-creation-grace-period", 10*time.Second, "Grace period after a successful spark-submit when driver pod not found errors will be retried. Useful if the driver pod can take some time to be created.")
 
 	command.Flags().BoolVar(&enableMetrics, "enable-metrics", false, "Enable metrics.")
 	command.Flags().StringVar(&metricsBindAddress, "metrics-bind-address", "0", "The address the metric endpoint binds to. "+

diff --git a/internal/controller/sparkapplication/controller_test.go b/internal/controller/sparkapplication/controller_test.go
@@ -91,9 +91,6 @@ var _ = Describe("SparkApplication Controller", func() {
 					ObjectMeta: metav1.ObjectMeta{
 						Name:      appName,
 						Namespace: appNamespace,
-						Labels: map[string]string{
-							common.LabelSparkAppName: app.Name,
-						},
 					},
 					Spec: v1beta2.SparkApplicationSpec{
 						MainApplicationFile: util.StringPtr("local:///dummy.jar"),
@@ -171,9 +168,6 @@ var _ = Describe("SparkApplication Controller", func() {
 					ObjectMeta: metav1.ObjectMeta{
 						Name:      appName,
 						Namespace: appNamespace,
-						Labels: map[string]string{
-							common.LabelSparkAppName: app.Name,
-						},
 					},
 					Spec: v1beta2.SparkApplicationSpec{
 						MainApplicationFile: util.StringPtr("local:///dummy.jar"),