-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Attempt to requeue after correct period Signed-off-by: Thomas Newton <[email protected]> * Syntactically correct Signed-off-by: Thomas Newton <[email protected]> * I think correct requeueing Signed-off-by: Thomas Newton <[email protected]> * Same treatment for the other retries Signed-off-by: Thomas Newton <[email protected]> * Tidy Signed-off-by: Thomas Newton <[email protected]> * Requeue after deleting resources Signed-off-by: Thomas Newton <[email protected]> * Try to fix submission status updates Signed-off-by: Thomas Newton <[email protected]> * Tidy Signed-off-by: Thomas Newton <[email protected]> * Correct usage of submitSparkApplication Signed-off-by: Thomas Newton <[email protected]> * Fix error logging Signed-off-by: Thomas Newton <[email protected]> * Bring back ExecutionAttempts increment that I forgot about Signed-off-by: Thomas Newton <[email protected]> * Log after reconcile complete Signed-off-by: Thomas Newton <[email protected]> * Fix setting submission ID Signed-off-by: Thomas Newton <[email protected]> * Tidy logging Signed-off-by: Thomas Newton <[email protected]> * Tidy Signed-off-by: Thomas Newton <[email protected]> * Tidy Signed-off-by: Thomas Newton <[email protected]> * Update comment Signed-off-by: Thomas Newton <[email protected]> * Start a new test Signed-off-by: Thomas Newton <[email protected]> * Working Fails submission and retries until retries are exhausted test Signed-off-by: Thomas Newton <[email protected]> * Add Application fails and retries until retries are exhausted Signed-off-by: Thomas Newton <[email protected]> * Tidy Signed-off-by: Thomas Newton <[email protected]> * Comments Signed-off-by: Thomas Newton <[email protected]> * Tidy Signed-off-by: Thomas Newton <[email protected]> * Move fail configs out of the examples directory Signed-off-by: Thomas Newton <[email protected]> * Fix lint Signed-off-by: Thomas Newton <[email protected]> * Move TimeUntilNextRetryDue to `pkg/util/sparkapplication.go` Signed-off-by: Thomas Newton <[email protected]> * Update internal/controller/sparkapplication/controller.go Co-authored-by: Yi Chen <[email protected]> Signed-off-by: Thomas Newton <[email protected]> * Update test/e2e/sparkapplication_test.go Co-authored-by: Yi Chen <[email protected]> Signed-off-by: Thomas Newton <[email protected]> * camelCase Signed-off-by: Thomas Newton <[email protected]> * make fo-fmt Signed-off-by: Thomas Newton <[email protected]> * PR comments Signed-off-by: Thomas Newton <[email protected]> --------- Signed-off-by: Thomas Newton <[email protected]> Co-authored-by: Yi Chen <[email protected]>
- Loading branch information
1 parent
d130b08
commit 735c7fc
Showing
7 changed files
with
307 additions
and
62 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
# | ||
# Copyright 2024 The Kubeflow authors. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
apiVersion: sparkoperator.k8s.io/v1beta2 | ||
kind: SparkApplication | ||
metadata: | ||
name: fail-submission | ||
namespace: default | ||
spec: | ||
type: Scala | ||
mode: cluster | ||
image: spark:3.5.2 | ||
imagePullPolicy: IfNotPresent | ||
mainClass: non-existent | ||
mainApplicationFile: local:///non-existent.jar | ||
sparkVersion: 3.5.2 | ||
restartPolicy: | ||
type: OnFailure | ||
onFailureRetries: 3 | ||
onFailureRetryInterval: 1 | ||
driver: | ||
labels: | ||
version: 3.5.2 | ||
cores: 1 | ||
memory: 512m | ||
serviceAccount: spark-operator-spark | ||
executor: | ||
labels: | ||
version: 3.5.2 | ||
instances: 1 | ||
cores: 1 | ||
memory: 512m |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
# | ||
# Copyright 2024 The Kubeflow authors. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
apiVersion: sparkoperator.k8s.io/v1beta2 | ||
kind: SparkApplication | ||
metadata: | ||
name: fail-submission | ||
namespace: default | ||
spec: | ||
type: Scala | ||
mode: cluster | ||
image: spark:3.5.2 | ||
imagePullPolicy: IfNotPresent | ||
mainClass: dummy | ||
mainApplicationFile: local:///dummy.jar | ||
sparkVersion: 3.5.2 | ||
restartPolicy: | ||
type: OnFailure | ||
onSubmissionFailureRetries: 3 | ||
onSubmissionFailureRetryInterval: 1 | ||
driver: | ||
labels: | ||
version: 3.5.2 | ||
cores: 1 | ||
memory: 512m | ||
serviceAccount: non-existent # This is the important part that causes submission to fail. | ||
executor: | ||
labels: | ||
version: 3.5.2 | ||
instances: 1 | ||
cores: 1 | ||
memory: 512m |
Oops, something went wrong.