Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pending commit id for cluster and source code name #994

Merged
merged 2 commits into from
Mar 20, 2019
Merged

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Mar 19, 2019

this might be introduced by accident during the refactoring
https://github.com/kubeflow/pipelines/pull/613/files#diff-8020d71fc47e179d2ef2b0a1bb13edcbR34


This change is Reviewable

@IronPan
Copy link
Member Author

IronPan commented Mar 19, 2019

/assign @gaoning777

Copy link
Contributor

@gaoning777 gaoning777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@IronPan
Copy link
Member Author

IronPan commented Mar 19, 2019

/test kubeflow-pipeline-e2e-test

@IronPan
Copy link
Member Author

IronPan commented Mar 20, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaoning777
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 44233c2 into master Mar 20, 2019
@IronPan IronPan deleted the testfix branch March 27, 2019 17:55
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants