Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(samples): Updated samples/core to V2 #9879

Merged
merged 1 commit into from
Mar 6, 2024
Merged

fix(samples): Updated samples/core to V2 #9879

merged 1 commit into from
Mar 6, 2024

Conversation

PratyushaRavi
Copy link
Contributor

@PratyushaRavi PratyushaRavi commented Aug 16, 2023 •
edited
Loading

Description of your changes:
Update samples to v2 pipelines.

Checklist:

@google-oss-prow
Copy link

Hi @PratyushaRavi. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot added size/L and removed size/S labels Aug 16, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@chensun chensun self-assigned this Aug 16, 2023
@PratyushaRavi
Updated samples to V2
2d170e5 
* Updated output_a_directory.py to V2

* Update output_a_directory_test.py to V2

* Update parallel_join.py to V2

* Update multiple_outputs.ipynb to V2

* Update multiple_outputs_test.py to V2

* Updated kfp_env_validation to V2

* Updated loop_parallelism to V2
@google-oss-prow
Copy link

@PratyushaRavi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-samples-v2 2d170e5 link false /test kubeflow-pipelines-samples-v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@PratyushaRavi PratyushaRavi changed the title fix(samples): Updated nested_condition.py to V2 fix(samples): Updated samples/core to V2 Aug 21, 2023
chensun
chensun approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Mar 6, 2024
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 1d96903 into kubeflow:master Mar 6, 2024
1 check passed
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 27, 2024
@PratyushaRavi @petethegreat
fix(samples): Updated samples/core to V2 (kubeflow#9879)
4224b89 
* Updated output_a_directory.py to V2

* Update output_a_directory_test.py to V2

* Update parallel_join.py to V2

* Update multiple_outputs.ipynb to V2

* Update multiple_outputs_test.py to V2

* Updated kfp_env_validation to V2

* Updated loop_parallelism to V2
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 29, 2024
@PratyushaRavi @petethegreat
fix(samples): Updated samples/core to V2 (kubeflow#9879)
640553d 
* Updated output_a_directory.py to V2

* Update output_a_directory_test.py to V2

* Update parallel_join.py to V2

* Update multiple_outputs.ipynb to V2

* Update multiple_outputs_test.py to V2

* Updated kfp_env_validation to V2

* Updated loop_parallelism to V2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chensun chensun chensun approved these changes

@animeshsingh animeshsingh Awaiting requested review from animeshsingh

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

Assignees

@chensun chensun

Labels
approved lgtm needs-ok-to-test size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PratyushaRavi @chensun