Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the component name to the docstring #976

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Mar 15, 2019

The component name is now always included in the task factory function docstring.
The name is already used as the function name, but when someone assigns it to the variable, the variable name replaces the original name.


This change is Reviewable

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Mar 15, 2019

#947

Copy link
Contributor

@hongye-sun hongye-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Mar 20, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 665d088 into kubeflow:master Mar 20, 2019
@Ark-kun Ark-kun deleted the Added-the-component-name-to-the-docstring branch March 29, 2019 21:44
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
* feature(backend): support embedded-status: minimal

Add logic to support embedded-status feature when using
minimal setting. For now, the TaskRun/Run status is retrieved
and inserted to PipelineRun.Status and stored into ml-pipeline
backend storage.

Signed-off-by: Yihong Wang <[email protected]>

* Add embedded-status feature flag

Use `full` as the default setting for embedded-status
feature flag.

Signed-off-by: Yihong Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants