-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(frontend): Update package.json
to be compatible with npm install
#8092
Conversation
…ve stories, update URLParser.test.ts.
frontend/src/lib/URLParser.test.ts
Outdated
const location = { | ||
pathname: '', | ||
search: '', | ||
} as any; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
createLocation
is no longer a function from history
, so I just used a based object instead.
@@ -66,9 +69,9 @@ describe('URLParser', () => { | |||
it('does not create new state when setting query param in-place', () => { | |||
location.search = '?searchkey=searchvalue'; | |||
|
|||
const historyLength = history.length; | |||
const historyLength = window.history.length; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The length
property of history
is no longer available, so I replaced it here with window.history
. Since window.history
does not have the search
property, I did not replace the full history
object, just the instances that used length
.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@zpChris: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
We are closing this PR because the
We tried adding These errors connect to the previous PR #7144; we still hope to remove
However, given time constraints on my internship I am closing this PR for now to work on other tasks to complete the KFPv2 Run Comparison page. |
Description of your changes:
package.json
by removing:storybook
dependencies due to conflictingbabel-loader
dependencieslicense-checker
to circumvent the403
warning described under "Notes"react-scripts
since thecraco
package already contains areact-scripts
versionstories
due to conflictingbabel-loader
dependencies, done through this processURLParser.test.ts
file to fix failing testsNotes:
npm ci
; however, we are making these fixes asnpm ci
runs into a403
error on my development environment, likely because a limited amount of access has been granted for the following service:npm ci
is still the desired setup method, as there could be additional unencountered errors withnpm install
since it ensure the installed dependencies have the same versions as all others.Checklist: