test

test/install-argo.sh

@@ -13,21 +13,21 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-
-kubectl config set-context $(kubectl config current-context) --namespace=default
-echo "Add necessary cluster role bindings"
-ACCOUNT=$(gcloud info --format='value(config.account)')
-kubectl create clusterrolebinding PROW_BINDING --clusterrole=cluster-admin --user=$ACCOUNT
-kubectl create clusterrolebinding DEFAULT_BINDING --clusterrole=cluster-admin --serviceaccount=default:default
-
-echo "install argo"
-ARGO_VERSION=v2.2.0
-mkdir -p ~/bin/
-export PATH=~/bin/:$PATH
-curl -sSL -o ~/bin/argo https://github.com/argoproj/argo/releases/download/$ARGO_VERSION/argo-linux-amd64
-chmod +x ~/bin/argo
-kubectl create ns argo
-kubectl apply -n argo -f https://raw.githubusercontent.com/argoproj/argo/$ARGO_VERSION/manifests/install.yaml
+#
+#kubectl config set-context $(kubectl config current-context) --namespace=default
+#echo "Add necessary cluster role bindings"
+#ACCOUNT=$(gcloud info --format='value(config.account)')
+#kubectl create clusterrolebinding PROW_BINDING --clusterrole=cluster-admin --user=$ACCOUNT
+#kubectl create clusterrolebinding DEFAULT_BINDING --clusterrole=cluster-admin --serviceaccount=default:default
+#
+#echo "install argo"
+#ARGO_VERSION=v2.2.0
+#mkdir -p ~/bin/
+#export PATH=~/bin/:$PATH
+#curl -sSL -o ~/bin/argo https://github.com/argoproj/argo/releases/download/$ARGO_VERSION/argo-linux-amd64
+#chmod +x ~/bin/argo
+#kubectl create ns argo
+#kubectl apply -n argo -f https://raw.githubusercontent.com/argoproj/argo/$ARGO_VERSION/manifests/install.yaml
 
 # Some workflows are deployed to the non-default namespace where the GCP credential secret is stored
 # In this case, the default service account in that namespace doesn't have enough permission

test/presubmit-tests-with-pipeline-deployment.sh

@@ -122,7 +122,7 @@ function clean_up {
   # delete the storage
   gcloud deployment-manager --project=${PROJECT} deployments delete ${KFAPP}-storage --quiet
 }
-trap clean_up EXIT
+#trap clean_up EXIT
 
 ${KUBEFLOW_SRC}/scripts/kfctl.sh init ${KFAPP} --platform ${PLATFORM} --project ${PROJECT} --skipInitProject
 
@@ -134,7 +134,12 @@ ${KUBEFLOW_SRC}/scripts/kfctl.sh apply k8s
 
 gcloud container clusters get-credentials ${TEST_CLUSTER}
 
-source "${DIR}/install-argo.sh"
+# Some workflows are deployed to the non-default namespace where the GCP credential secret is stored
+# In this case, the default service account in that namespace doesn't have enough permission
+echo "add service account for running the test workflow"
+kubectl config set-context $(kubectl config current-context) --namespace=default
+kubectl create serviceaccount test-runner -n ${NAMESPACE}
+kubectl create clusterrolebinding test-admin-binding --clusterrole=cluster-admin --serviceaccount=${NAMESPACE}:test-runner
 
 echo "submitting argo workflow to build docker images for commit ${PULL_PULL_SHA}..."
 ARGO_WORKFLOW=`argo submit ${DIR}/build_image.yaml \