Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(gcp): ai platform pipelines use emissary tooltip update #6331

Merged
merged 3 commits into from
Aug 18, 2021

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Aug 13, 2021

Description of your changes:
Part of #6294

before the PR, it looked like the following on the UI, basically the format doesn't support markdown, so I have to reduce the number of links and what content to include here:
image

Checklist:


Refer to migrating to emissary executor documentation for migration instructions.
Warning, docker executor does not work on Google Kubernetes Engine (GKE) 1.19+
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Docker executor does not work on Google Kubernetes Engine (GKE) 1.19+ by default, as docker container runtime is no longer the default container runtime; docker container runtime will be deprecated on GKE 1.20+."

docker, so docker executor does not work properly. Emissary executor is not
coupled to a specific container runtime, so it works properly on any
Kubernetes clusters including GKE 1.19+ with containerd as runtime.
To prepare for the migration to emissary executor, refer to [1] for more details.
Copy link

@shuesc1 shuesc1 Aug 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

".....refer to [1] for more details." -> "refer to Argo Workflow Executors[1] for more details."

(deprecated) as the node image. For more information, refer to
[GKE Node Images](https://cloud.google.com/kubernetes-engine/docs/concepts/node-images).
To keep using docker executor for GKE 1.19+, configure your node pools to
use docker as container runtime by selecting "Container-Optimized OS with Docker (cos)" (deprecated)
Copy link

@shuesc1 shuesc1 Aug 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"...use docker as a container runtime by selecting "Container-Optimized OS with Docker (cos)" (deprecated) as the node image[2]."

@kramachandran
Copy link

This feels way to long to be a tool tip -- can we shorten it? Just focus on two facts - you need Emissary if you want to GKE 1.19+; and that it causes a breaking change?

Comment on lines 180 to 182
Warning, docker executor does not work on Google Kubernetes Engine (GKE) 1.19+
by default, because docker container runtime is no longer the default. Furthermore,
docker container runtime will be deprecated on GKE 1.20+.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does the following description sound?

Warning: Use emissary executor for GKE 1.19+. Docker container runtime is no longer the default node image option since GKE 1.19.

@Bobgy
Copy link
Contributor Author

Bobgy commented Aug 17, 2021

Thank you for the review!
Let me try to resolve Karthik's comment first.

This feels way too long to be a tool tip -- can we shorten it? Just focus on two facts - you need Emissary if you want to GKE 1.19+; and that it causes a breaking change?

I think this is a great advice. For clarification, on GKE 1.19+, people can configure node image to use docker container runtime + docker executor too.

What do you think about rough ideas of the following?

Warning, Kubeflow Pipelines does not work on Google Kubernetes Engine (GKE) 1.19+ by
default. You cluster node image must be configured to use docker as container runtime.

Using emissary executor removes the restriction on container runtime, but note some of
your pipelines may require manual migrations.

Refer to Argo Workflow Executors documentation for detailed configuration and migration instructions for both options:
https://www.kubeflow.org/docs/components/pipelines/installation/choose-executor/

@karkumar
Copy link

Thanks the updated text seems much clearer.

@Bobgy Bobgy added the lgtm label Aug 18, 2021
@Bobgy
Copy link
Contributor Author

Bobgy commented Aug 18, 2021

/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 61dedb1 into kubeflow:master Aug 18, 2021
@Bobgy Bobgy deleted the emissary-mkp branch August 18, 2021 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants