Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade argo-workflows to v3.1.0. Part of #5718 #5922

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Jun 27, 2021

Description of your changes:
Part of #5718

Changes

  • upgrade argo go module
  • upgrade argo manifests
  • update licenses for go binaries
  • update documentation for how to upgrade argo
  • fix everything after the upgrade

Checklist:

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 27, 2021

/cc @NikeNano

@Bobgy Bobgy changed the title feat: upgrade argo-workflows to v3.1.0. Fixes #5718 feat: upgrade argo-workflows to v3.1.0, use emissary executor by default. Fixes #5718, fixes #1654, fixes #5663 Jun 27, 2021
@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 28, 2021

I got an error standard_init_linux.go:211: exec user process caused "permission denied" from the frontend integration test pod in kubeflow-pipeline-e2e-test.

Related dockerfile:

COPY --chown=seluser . /src

EDIT: actually, I think I made a mistake of writing command as run_test.sh, but it should be ./run_test.sh.

ENTRYPOINT [ "./run_test.sh" ]

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 28, 2021

/retest

@Bobgy Bobgy changed the title feat: upgrade argo-workflows to v3.1.0, use emissary executor by default. Fixes #5718, fixes #1654, fixes #5663 feat!: upgrade argo-workflows to v3.1.0, use emissary executor by default. Fixes #5718, fixes #1654, fixes #5663 Jun 28, 2021
@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 28, 2021

/hold
Filed upstream issue for using argo emissary executor with rootless container: argoproj/argo-workflows#6238.

The e2e test failure is at selenium image:

COPY --chown=seluser . /src
. It runs as non-root.

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 28, 2021

Potential solutions

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 28, 2021

Because the remaining problems are related to switching to emissary executor. I'd like to separate the PR into two:

  1. Upgrade argo to v3.1.0
  2. Switch to emissary executor

This PR will only upgrade argo workflows to v3.1.0

@Bobgy Bobgy changed the title feat!: upgrade argo-workflows to v3.1.0, use emissary executor by default. Fixes #5718, fixes #1654, fixes #5663 feat: upgrade argo-workflows to v3.1.0. Part of #5718 Jun 28, 2021
@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 28, 2021

/unhold
this PR only upgrades argo to v3.1.0

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 28, 2021

/approve

self approving the low risk upgrade PR, will request further review for switching to emissary executor

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants