-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade argo-workflows to v3.1.0. Part of #5718 #5922
Conversation
/cc @NikeNano |
manifests/kustomize/third-party/argo/installs/namespace/cluster-scoped/kustomization.yaml
Show resolved
Hide resolved
...ze/third-party/argo/upstream/manifests/quick-start/base/artifact-repositories-configmap.yaml
Show resolved
Hide resolved
...omize/third-party/argo/upstream/manifests/quick-start/base/kubelet-executor-clusterrole.yaml
Show resolved
Hide resolved
...fests/kustomize/third-party/argo/upstream/manifests/quick-start/base/minio/minio-deploy.yaml
Show resolved
Hide resolved
...e/third-party/argo/upstream/manifests/quick-start/base/prometheus/prometheus-deployment.yaml
Show resolved
Hide resolved
I got an error Related dockerfile:
EDIT: actually, I think I made a mistake of writing command as
|
/retest |
/hold The e2e test failure is at selenium image:
|
Potential solutions
|
Because the remaining problems are related to switching to emissary executor. I'd like to separate the PR into two:
This PR will only upgrade argo workflows to v3.1.0 |
/unhold |
/approve self approving the low risk upgrade PR, will request further review for switching to emissary executor |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
Part of #5718
Changes
Checklist: