-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the List run to get all runs #583
Conversation
/assign @yebrahim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for fixing this.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ubeflow#583) * Instead of using ksonnet to manage the PV and PVC for NFS switch to using kustomize and update the playbook. Fix kubeflow#582
…a event source (kubeflow#583) * Fix flaky test for deleting canary * Add addressable duck type * Support internal route * Fix internal route host * Move validate after preprocess * Separate load json * Fix response * clear output * Fix tests * Fix predictor host * Fix predictor host * Fix virtual service tests * Fix controller tests * Add more instructions * Create external service for the virtual service host * Use localgateway host constant * Update kafka example doc * Add isvc addressable cluster role * Add diagram * Reference helm3 * Fix v1 type merge * Address comment * Remove notebook * Add kustomize requirement
We now don't assume runs always have resource reference, the sql query need to update to avoid assuming it exist. Otherwise the runs created not inside an experiment won't show up in the list run view.
Query change
Before
After
This change is