SDK/Components - Do not crash on non-hashable objects #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n's `dict.get` throws exception when it thinks that the object is not suitable for key.
qimingj
approved these changes
Dec 11, 2018
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
qimingj
pushed a commit
to qimingj/pipelines
that referenced
this pull request
Dec 11, 2018
…n's `dict.get` throws exception when it thinks that the object is not suitable for key. (kubeflow#511)
|
/test kubeflow-pipeline-sample-test |
neuromage
pushed a commit
to neuromage/pipelines
that referenced
this pull request
Dec 22, 2018
…n's `dict.get` throws exception when it thinks that the object is not suitable for key. (kubeflow#511)
Ark-kun
deleted the
SDK/Components---Do-not-crash-on-non-hashable-objects
branch
Linchin
pushed a commit
to Linchin/pipelines
that referenced
this pull request
Apr 11, 2023
* Add a method to build checkout repos dictionary * Fix error * Simplify method * caller pass in defaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently Python's
dict.getthrows exception when it thinks that the object is not suitable for key.This change is